fix: Forced variation not available in experiment #292
Conversation
lib/optimizely.rb
Outdated
| variation_id = if !variation | ||
| experiment_id != '' ? config.get_variation_id_from_key_by_experiment_id(experiment_id, variation_key) : '' | ||
| else | ||
| variation ? variation['id'] : '' | ||
| end |
There was a problem hiding this comment.
| variation_id = if !variation | |
| experiment_id != '' ? config.get_variation_id_from_key_by_experiment_id(experiment_id, variation_key) : '' | |
| else | |
| variation ? variation['id'] : '' | |
| end | |
| variation_id = variation ? variation['id'] : '' |
If it's null from get_flag_variagtion(), then get_variation_id_from_key_by_experiment_id() will also return null.
There was a problem hiding this comment.
This is independent of flag_key, for a/b experiments this will return non-null and get_flag_variation will return null.
There was a problem hiding this comment.
@msohailhussain A good point! I still see this code can be refactored. Can consider the same comment for this:
https://github.com/optimizely/php-sdk/pull/237/files#r770133288
| @@ -298,8 +298,8 @@ def decide_for_keys(user_context, keys, decide_options = []) | |||
| decisions | |||
| end | |||
|
|
|||
| 8000 | def get_flag_variation_by_key(flag_key, variation_key) | ||
| project_config.get_variation_from_flag(flag_key, variation_key) | |||
| def get_flag_variation(flag_key, target_value, attribute) | |||
There was a problem hiding this comment.
please add description of this method.
lib/optimizely.rb
Outdated
| variation_id = if !variation | ||
| experiment_id != '' ? config.get_variation_id_from_key_by_experiment_id(experiment_id, variation_key) : '' | ||
| else | ||
| variation ? variation['id'] : '' | ||
| end |
There was a problem hiding this comment.
@msohailhussain A good point! I still see this code can be refactored. Can consider the same comment for this:
https://github.com/optimizely/php-sdk/pull/237/files#r770133288
Summary
Test plan