10000 feat: Duplicate experiment key issue with multi feature flag by ozayr-zaviar · Pull Request #282 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

feat: Duplicate experiment key issue with multi feature flag #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 26, 2021
Merged

feat: Duplicate experiment key issue with multi feature flag #282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a7c6212
init
ozayr-zaviar Jul 12, 2021
20a58a0
fix key fetch
ozayr-zaviar Jul 12, 2021
0134661
testcase fixed
ozayr-zaviar Jul 12, 2021
a5b8636
testcases added and variable name fixed
ozayr-zaviar Jul 13, 2021
a3645bd
logging tests added
ozayr-zaviar Jul 13, 2021
ba3a009
lint fixes
ozayr-zaviar Jul 13, 2021
16a2dce
testcase fixes
ozayr-zaviar Jul 13, 2021
009a86e
key created from all experiments
ozayr-zaviar Jul 15, 2021
450fded
correction
ozayr-zaviar Jul 15, 2021
eecae46
experiment_key_map intialized
ozayr-zaviar Jul 15, 2021
729a70b
revert
ozayr-zaviar Jul 15, 2021
6ed69a1
replaced all experiment keys with ids
ozayr-zaviar Jul 15, 2021
cc2af3f
All FSC test cases fixed
ozayr-zaviar Jul 16, 2021
8bc63dd
testcases fixed
ozayr-zaviar Jul 18, 2021
2aca129
coverall improved
ozayr-zaviar Jul 18, 2021
697e13d
extra line removed
ozayr-zaviar Jul 18, 2021
326b771
comments addressed
ozayr-zaviar Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testcases fixed
  • Loading branch information
@ozayr-zaviar
ozayr-zaviar committed Jul 18, 2021
commit 8bc63dd8d1f1bee00f59100229a7f5c69d8264c8
2 changes: 1 addition & 1 deletion lib/optimizely/project_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def get_variation_from_id(experiment_key, variation_id); end

def get_variation_from_id_by_experiment_id(experiment_id, variation_id); end

def get_variation_from_key_by_experiment_id(experiment_id, variation_key); end
def get_variation_id_from_key_by_experiment_id(experiment_id, variation_key); end

def get_variation_id_from_key(experiment_key, variation_key); end

Expand Down
3 changes: 1 addition & 2 deletions spec/config/datafile_project_config_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,8 +889,7 @@

config_body_json = JSON.dump(config_body)
project_config = Optimizely::DatafileProjectConfig.new(config_body_json, logger, error_handler)

expect(project_config.get_variation_from_key_by_experiment_id(experiment_id, variation_key)[feature_enabled]).to eq(false)
expect(project_config.get_variation_id_from_key_by_experiment_id(experiment_id, variation_key)).to eq('100029')
end
end

Expand Down
Loading
0