10000 ci: Checking FSC on Pr 217 by msohailhussain · Pull Request #223 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

ci: Checking FSC on Pr 217 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ci: Checking FSC on Pr 217 #223

wants to merge 5 commits into from

Conversation

msohailhussain
Copy link
Contributor

Summary

  • The "what"; a concise description of each logical change
  • Another change

The "why", or other context.

Test plan

Issues

jasonkarns and others added 4 commits October 26, 2019 09:10
@jasonkarns
Moves Project to its own conventional file
6dcb37e
@jasonkarns
Trim requires
d32a9e0 
Remove requires from project.rb which aren't referenced.
Add missing requires to project.rb which _are_ referenced.
Remove requires from optimizely.rb which aren't referenced, but are
already required by project.rb.
@jasonkarns
Remove redundant namespace prefix
458a699
@msohailhussain
Merge branch 'master' into conventional-file
e90de35
@msohailhussain msohailhussain requested a review from a team as a code owner December 3, 2019 22:35
@oakbani oakbani closed this Dec 4, 2019
@oakbani oakbani reopened this Dec 4, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.518% when pulling 1a0675d on pr-217 into c720b02 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.518% when pulling 1a0675d on pr-217 into c720b02 on master.

@coveralls
Copy link
coveralls commented Dec 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 99.515% when pulling 1a0675d on pr-217 into c720b02 on master.

@oakbani
Copy link
Contributor
oakbani commented Dec 4, 2019

#217 is ready to merge. Fixed linting issues. Generated a new rubocop todo file.

@oakbani oakbani closed this Dec 4, 2019
@oakbani oakbani deleted the pr-217 branch August 19, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msohailhussain @coveralls @oakbani @jasonkarns
0