feat(epmodel): Event Processor datamodel #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
commented
Jul 19, 2019
| # | ||
| require_relative 'user_event' | ||
| module Optimizely | ||
| class ConversionEvent < UserEvent |
8000
There was a problem hiding this comment.
where are other attributes?
bot filter?
| require_relative 'user_event' | ||
| module Optimizely | ||
| class ConversionEvent < UserEvent | ||
| attr_accessor :event, :event_tags |
There was a problem hiding this comment.
can't we just define attr_reader and pass it in a constructor?
| } | ||
| end | ||
|
|
||
| class Builder |
There was a problem hiding this comment.
do we really need builder classes in ruby ?
|
|
||
| module Optimizely | ||
| class EventContext | ||
| attr_reader :account_id, :project_id, :revision, :client_name, |
There was a problem hiding this comment.
how you will set these values?
| require_relative 'user_event' | ||
| module Optimizely | ||
| class ImpressionEvent < UserEvent | ||
| attr_reader :user_id, :user_attributes |
There was a problem hiding this comment.
it's not user_attributes, it's visitor_attributes
| module Optimizely | ||
| class ImpressionEvent < UserEvent | ||
| attr_reader :user_id, :user_attributes | ||
| attr_accessor :experiment, :variation |
There was a problem hiding this comment.
why accessor?
There was a problem hiding this comment.
| @timestamp = timestamp | ||
| @revenue = revenue | ||
| @value = value | ||
| @event_tags = event_tags |
There was a problem hiding this comment.
these are just tags?
| # | ||
| module Optimizely | ||
| class UserEvent | ||
| attr_reader :context, :uuid, :timestamp |
There was a problem hiding this comment.
write it as event_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Impression Event
Conversion Event