enhancement: Remove mmh3 external dependency and use internal pymmh3 in place #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msohailhussain Looks like three of the libraries were able to be removed with no issues, the others had to stay since they were dependencies for other libraries. We should be able to release this or something along these lines as a light version of the python-sdk by changing a few fields in the setup.py file pre release. What are your thoughts? |
|
This PR is in attention to issue: #232 |
Mat001
approved these changes
Nov 1, 2021
|
@msohailhussain Confirmed tests work on windows machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issues