8000 ci: Install a compatible version of cryptography for pypy and pypy3 in travis config by msohailhussain · Pull Request #320 · optimizely/python-sdk · GitHub
[go: up one dir, main page]

Skip to content

ci: Install a compatible version of cryptography for pypy and pypy3 in travis config #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2021

Conversation

msohailhussain
Copy link
Contributor
@msohailhussain msohailhussain commented Mar 4, 2021

Summary

Unit tests on Python pypy and pypy3 have been failing consistently for quite some time. On detailed investigation, cryptography package is required by the requests[security] module. Although the latest cryptography version does support pypy, it doesn't build for some reason.

Setting cryptography package to a static previous version revealed that Python 3.4 support has been dropped after cryptography 2.8.

Therefore, instead of modifying requirements file, we install the correct working version of cryptography in before_install phase of pyp build.

Test plan

All checks continue to pass.

Issues

@coveralls
Copy link
coveralls commented Mar 5, 2021

Coverage Status

Coverage remained the same at 95.883% when pulling b6e5e38 on sohail/pypifix into 5fefd2b on master.

@oakbani oakbani changed the title pypy fix - WIP ci: Install a compatible version of cryptography for pypy and pypy3 in travis config Mar 5, 2021
@msohailhussain msohailhussain marked this pull request as ready for review March 5, 2021 18:20
@msohailhussain msohailhussain requested a review from a team as a code owner March 5, 2021 18:20
@msohailhussain msohailhussain removed their assignment Mar 5, 2021
.travis.yml Outdated
- stage: 'Test'
python: "pypy"
before_install:
- pip install "cryptography>=1.3.4,<=3.1.1" # installing in before_install doesn't re-install a latest version of the same package in the next stage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix grammatical error: Change "a latest version of the same" to "the latest version of the same".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Mat001 added 2 commits March 5, 2021 12:15
Add comment to README about installing cryptography when using PyPy
Added additional explanation
Copy link
Contributor
@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 46651fa into master Mar 12, 2021
@jaeopt jaeopt deleted the sohail/pypifix branch March 12, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0