-
Notifications
You must be signed in to change notification settings - Fork 36
ci: Install a compatible version of cryptography for pypy and pypy3 in travis config #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
- stage: 'Test' | ||
python: "pypy" | ||
before_install: | ||
- pip install "cryptography>=1.3.4,<=3.1.1" # installing in before_install doesn't re-install a latest version of the same package in the next stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix grammatical error: Change "a latest version of the same" to "the latest version of the same".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Add comment to README about installing cryptography when using PyPy
Added additional explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Unit tests on Python pypy and pypy3 have been failing consistently for quite some time. On detailed investigation, cryptography package is required by the requests[security] module. Although the latest cryptography version does support pypy, it doesn't build for some reason.
Setting cryptography package to a static previous version revealed that Python 3.4 support has been dropped after cryptography 2.8.
Therefore, instead of modifying requirements file, we install the correct working version of cryptography in before_install phase of pyp build.
Test plan
All checks continue to pass.
Issues