8000 [FSSDK-10993] additional cleanup for project config manager by raju-opti · Pull Request #977 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-10993] additional cleanup for project config manager #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2024
Merged

[FSSDK-10993] additional cleanup for project config manager #977

merged 5 commits into from
Dec 11, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

Issues

  • FSSDK-10993

@raju-opti raju-opti requested a review from a team as a code owner December 11, 2024 17:19
junaed-optimizely
junaed-optimizely approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor
@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. LGTM! Just one NIT

@coveralls
Copy link

Coverage Status

coverage: 87.059% (+0.05%) from 87.005%
when pulling 8a6eb7f on raju/config-cleanup
into e119925 on master.

@raju-opti raju-opti merged commit faee6c7 into master Dec 11, 2024
16 of 19 checks passed
@raju-opti raju-opti deleted the raju/config-cleanup branch December 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely
0