10000 [FSSDK-9615] log error when datafile fetch request fails by raju-opti · Pull Request #904 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9615] log error when datafile fetch request fails #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2024
Merged

[FSSDK-9615] log error when datafile fetch request fails #904

merged 2 commits into from
Feb 23, 2024

Conversation

raju-opti
Copy link
Contributor

Summary

  • log an error when datafile fetch request returns a non success status code

Test plan

  • added test for the logging

Issues

  • FSSDK-9615

@raju-opti raju-opti requested a review from a team as a code owner February 23, 2024 05:13
@coveralls
Copy link
coveralls commented Feb 23, 2024 •
edited
Loading

Coverage Status

coverage: 90.373% (-0.007%) from 90.38%
when pulling 37ea6c5 on raju/fetch-log
into d5e6a05 on master.

@raju-opti
Copy link
Contributor Author

solves #784

mikechu-optimizely
mikechu-optimizely approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor
@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mikechu-optimizely
Copy link
Contributor

Actually, please update the copyright date.

We probably need to devise an Actions workflow that looks for that on files included in PRs

@raju-opti raju-opti merged commit e938e3c into master Feb 23, 2024
@raju-opti raju-opti deleted the raju/fetch-log branch February 23, 2024 14:36
@raju-opti raju-opti mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @mikechu-optimizely
0