8000 [FSSDK-9607] add pixelUrl to OdpConfig by andrewleap-optimizely · Pull Request #888 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9607] add pixelUrl to OdpConfig #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2024
Merged

[FSSDK-9607] add pixelUrl to OdpConfig #888

merged 4 commits into from
Jan 17, 2024

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Changed the ODP pixelUrl to be read from the datafile instead of being hard coded in the SDK.

Ticket

FSSDK-9607

@coveralls
Copy link
coveralls commented Jan 12, 2024 •
edited
Loading

Coverage Status

coverage: 90.411% (+0.009%) from 90.402%
when pulling 55033a8 on aleap/add-pixel-url-to-odp-config
into 7e03647 on master.

mikechu-optimizely
mikechu-optimizely reviewed Jan 16, 2024
View reviewed changes
@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review January 17, 2024 15:02
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner January 17, 2024 15:02
mikechu-optimizely
mikechu-optimizely approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor
@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts but nothing show-stopping. LGTM.

raju-opti
raju-opti requested changes Jan 17, 2024
View reviewed changes
raju-opti
raju-opti approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor
@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit f61dc52 into master Jan 17, 2024
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add-pixel-url-to-odp-config branch January 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@raju-opti raju-opti raju-opti approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewleap-optimizely @coveralls @mikechu-optimizely @raju-opti
0