8000 [FSSDK-9361] fix failing fsc tests for odp config update by raju-opti · Pull Request #830 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]

Skip to content

[FSSDK-9361] fix failing fsc tests for odp config update #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related em 8000 ails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

raju-opti
Copy link
Contributor
@raju-opti raju-opti commented Jun 7, 2023

Summary

On odp config update:

  • All queued odp events should be flushed
  • Cache should be reset

These tests were previously failing because on datafile update, odp config was not being updated. That is fixed in this PR.

Test plan

  • All existing tests should pass

Issues

@raju-opti raju-opti r 8000 equested a review from a team as a code owner June 7, 2023 12:25
@coveralls
Copy link

Coverage Status

coverage: 90.515%. remained the same when pulling e3fae1d on raju/fix-fsc into 5765e28 on master.

@raju-opti raju-opti changed the title [FSSDK-9361] fix failing fsc test for sending all events on config update [FSSDK-9361] fix failing fsc tests for odp config update Jun 7, 2023
Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 280f2a0 into master Jun 8, 2023
@raju-opti raju-opti deleted the raju/fix-fsc branch June 8, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0