8000 [FSSDK-8887] Refactor non-code-path resources from FS => FX by opti-jnguyen · Pull Request #803 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-8887] Refactor non-code-path resources from FS => FX #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 17, 2023
Merged

[FSSDK-8887] Refactor non-code-path resources from FS => FX #803

merged 9 commits into from
Mar 17, 2023

Conversation

opti-jnguyen
Copy link
Contributor

Summary

  • Updated readme file and matched its format with the provided sample readme file.
  • Removed all occurrences of full stack with Optimizely Feature Experimentation

Refactor required due to rename of Full Stack product to Feature Experimentation.

Test plan

All tests should pass.

Issues

@opti-jnguyen opti-jnguyen requested a review from a team as a code owner March 10, 2023 19:26
@coveralls
Copy link
coveralls commented Mar 10, 2023 •
edited
Loading

Coverage Status

Coverage: 90.117%. Remained the same when pulling c351abc on jnguyen/update-readme into 7808c73 on master.

russell-loube-optimizely
russell-loube-optimizely reviewed Mar 10, 2023
View reviewed changes
8000
russell-loube-optimizely
russell-loube-optimizely reviewed Mar 13, 2023
View reviewed changes
andrewleap-optimizely
andrewleap-optimizely approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor
@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@opti-jnguyen opti-jnguyen merged commit 198c46e into master Mar 17, 2023
@opti-jnguyen opti-jnguyen deleted the jnguyen/update-readme branch March 17, 2023 15:04
@opti-jnguyen opti-jnguyen changed the title Refactor non-code-path resources from FS => FX [FSSDK-8887] Refactor non-code-path resources from FS => FX Mar 17, 2023
opti-jnguyen added a commit that referenced this pull request Mar 17, 2023
@opti-jnguyen
Refactor non-code-path resources from FS => FX (#803)
4182615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russell-loube-optimizely russell-loube-optimizely russell-loube-optimizely left review comments

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@opti-jnguyen opti-jnguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opti-jnguyen @coveralls @andrewleap-optimizely @russell-loube-optimizely
0