8000 chore: Prep for release 4.8.0 by zashraf1985 · Pull Request #726 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

chore: Prep for release 4.8.0 #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2021
Merged

chore: Prep for release 4.8.0 #726

merged 2 commits into from
Nov 29, 2021

Conversation

zashraf1985
Copy link
Contributor

No description provided.

@zashraf1985 zashraf1985 requested a review from a team as a code owner November 29, 2021 00:54
@zashraf1985 zashraf1985 removed their assignment Nov 29, 2021
@coveralls
Copy link
coveralls commented Nov 29, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 97.138% when pulling e1fd832 on zeeshan/prep-for-release-4.8.0 into a4a31dd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.138% when pulling 69b6472 on zeeshan/prep-for-release-4.8.0 into a4a31dd on master.

The-inside-man
The-inside-man approved these changes Nov 29, 2021
View reviewed changes
Copy link
@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small comments but LGTM!

The-inside-man
The-inside-man approved these changes Nov 29, 2021
View reviewed changes
Copy link
@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zashraf1985 zashraf1985 merged commit 9e5e51c into master Nov 29, 2021
@zashraf1985 zashraf1985 deleted the zeeshan/prep-for-release-4.8.0 branch November 29, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-inside-man The-inside-man The-inside-man approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @coveralls @The-inside-man
0