10000 fix stubbing issues and prep for release `0.3.1` for logging package by zashraf1985 · Pull Request #711 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix stubbing issues and prep for release 0.3.1 for logging package #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix stubbing issues and prep for release 0.3.1 for logging package #711

merged 1 commit into from
Oct 13, 2021

Conversation

zashraf1985
Copy link
Contributor

Summary

Upgrading to latest typescript version is causing stubbing issues and failing some unit tests. Downgrading the typescript version to 3.8.x temporarily to fix this.

Test plan

  • Manually tested thoroughly.
  • All existing tests pass

@zashraf1985 zashraf1985 requested a review from a team as a code owner October 13, 2021 18:52
@zashraf1985 zashraf1985 removed their assignment Oct 13, 2021
yavorona
yavorona approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor
@yavorona yavorona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.072% when pulling a0d0c9c on zeeshan/logging-downgrade-typescript into a7f5050 on master.

@zashraf1985 zashraf1985 merged commit 89d5067 into master Oct 13, 2021
@zashraf1985 zashraf1985 deleted the zeeshan/logging-downgrade-typescript branch October 13, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorona yavorona yavorona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zashraf1985 @coveralls @yavorona
0