8000 feat: Added project_config_manager interface by yavorona · Pull Request #572 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

feat: Added project_config_manager interface #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2020
Merged

feat: Added project_config_manager interface #572

merged 4 commits into from
Sep 24, 2020

Conversation

yavorona
Copy link
Contributor
@yavorona yavorona commented Sep 22, 2020 •
edited
Loading

Summary

  • Added project_config_manager interface

Tests

  • Existing unit tests

@yavorona yavorona added the WIP label Sep 22, 2020
@yavorona yavorona requested a review from a team as a code owner September 22, 2020 00:43
@yavorona yavorona self-assigned this Sep 22, 2020
@yavorona yavorona force-pushed the pnguen/project_config_manager_interface branch 2 times, most recently from a157626 to 32576f4 Compare September 23, 2020 21:41
@yavorona yavorona removed their assignment Sep 23, 2020
@yavorona yavorona removed the WIP label Sep 23, 2020
@yavorona yavorona requested a review from mjc1283 September 23, 2020 21:43
@coveralls
Copy link
coveralls commented Sep 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.638% when pulling a9b71e4 on pnguen/project_config_manager_interface into 7fdb06a on master.

mjc1283
mjc1283 suggested changes Sep 23, 2020
View reviewed changes
packages/optimizely-sdk/lib/core/project_config/project_config_manager.d.ts Outdated
* Returns the optimizely config object
* @return {ProjectConfig}
*/
getOptimizelyConfig(): ProjectConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is wrong - this returns an OptmizelyConfig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thanks! It is a totally different OptimizelyConfig object. I updated the comments and the interface as well.

packages/optimizely-sdk/lib/core/project_config/project_config_manager.d.ts Outdated
* Stop the internal datafile manager and remove all update listeners
* @return {Promise|void}
*/
stop(): Promise<void> | void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it never returns a promise, just void.

@yavorona yavorona force-pushed the pnguen/project_config_manager_interface branch from 32576f4 to a9b71e4 Compare September 24, 2020 00:03
@yavorona yavorona removed their assignment Sep 24, 2020
@yavorona yavorona merged commit 90c5fdb into master Sep 24, 2020
@yavorona yavorona deleted the pnguen/project_config_manager_interface branch September 24, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavorona @coveralls @mjc1283
0