feat: Convert fns module to TS #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f8b498 to
e80a843
Compare
yavorona
commented
Aug 17, 2020
| @@ -15,20 +15,23 @@ | |||
| */ | |||
| import { generateUUID as uuid, keyBy as keyByUtil } from '@optimizely/js-sdk-utils'; | |||
|
|
|||
| var MAX_SAFE_INTEGER_LIMIT = Math.pow(2, 53); | |||
| import { C 10000 onfig } from '@optimizely/optimizely-sdk'; | |||
There was a problem hiding this comment.
I believe this should be the right way of importing Config interface as it compiles successfully with npm run build. However, the TS compiler is failing with Cannot find module '@optimizely/optimizely-sdk' error, not sure why. Any ideas @mjc1283? 🥺
There was a problem hiding this comment.
This is now outdated. I changed this to type any after discussing with @mikeng13 . Please see the most recent commit for reference.
mjc1283
suggested changes
Aug 19, 2020
| export var assign = function (target) { | ||
| if (!target) { | ||
| // eslint-disable-next-line | ||
| export function assign(...args: [any]): any { |
There was a problem hiding this comment.
Is there a better type signature we can use here? The type of Object.assign is assign<T, U>(target: T, source: U): T & U.
34a8c7e to
e07e6ed
Compare
yavorona
commented
Aug 19, 2020
|
|
||
| export var assign = function (target) { | ||
| // eslint-disable-next-line | ||
| export function assign(target: any, ...sources: any[]): any { |
There was a problem hiding this comment.
@mjc1283 let me know if that works. I assumed we still want to go with any is this case.
mjc1283
approved these changes
Aug 20, 2020
990d06c to
b48acf9
Compare
ce4e5bf to
b071757
Compare
mjc1283
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fnsmodule from JS to TS.Test plan