10000 refactor(core): Run Prettier on packages/optimizely-sdk by circAssimilate · Pull Request #420 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

refactor(core): Run Prettier on packages/optimizely-sdk #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

refactor(core): Run Prettier on packages/optimizely-sdk #420

merged 1 commit into from
Mar 4, 2020

Conversation

circAssimilate
Copy link
Contributor
@circAssimilate circAssimilate commented Mar 3, 2020 •
edited
Loading

Summary

  • Run prettier --write "**/*.js" in packages/optimizely-sdk
  • Run prettier --write "**/*.ts" in packages/optimizely-sdk

Per the convo in Slack, we thought it would be a good idea to run Prettier on the entire optimizely-sdk directory. Going forward, prettier will automatically run if the users IDE has the editorConfig setup as such. For VS Code, I personally like to add the "editor.formatOnSave": true, to my settings.json.

Test plan

  • Ensure tests pass

@circAssimilate circAssimilate requested a review from a team as a code owner March 3, 2020 20:23
@circAssimilate circAssimilate mentioned this pull request Mar 3, 2020
Closed
@coveralls
Copy link
coveralls commented Mar 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 97.259% when pulling e5dd734 on derek/run_prettier_on_optimizely_sdk into 6e00881 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 97.31% when pulling 6d296bf on derek/run_prettier_on_optimizely_sdk into a04a74a on master.

@circAssimilate circAssimilate removed their assignment Mar 3, 2020
@circAssimilate circAssimilate force-pushed the derek/run_prettier_on_optimizely_sdk branch from 6d296bf to e5dd734 Compare March 4, 2020 17:17
@circAssimilate circAssimilate merged commit caf36ae into master Mar 4, 2020
@circAssimilate circAssimilate deleted the derek/run_prettier_on_optimizely_sdk branch March 4, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@circAssimilate @coveralls @mjc1283 @optimizely-codereview-bot
0