Removed dependency on lodash.map #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Feb 20, 2020
| @@ -33,7 +33,17 @@ module.exports = { | |||
| filter: require('lodash/filter'), | |||
| forEach: require('lodash/forEach'), | |||
| forOwn: require('lodash/forOwn'), | |||
| map: require('lodash/map'), | |||
| map: function(obj, callback) { | |||
There was a problem hiding this comment.
This map function seems unnecessary. I suggest we just update all the call sites to do what's necessary.
There was a problem hiding this comment.
There was only one use. I updated that to use Object.keys and removed map method from fns altogether
mjc1283
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To reduce package size, we are trying to gradually get rid of lodash library. This PR removes the
mapfunction.Test plan
All tests pass after this change.