8000 Removed dependency on lodash.isArray by fayyazarshad · Pull Request #400 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

Removed dependency on lodash.isArray #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2020
Merged

Removed dependency on lodash.isArray #400

merged 5 commits into from
Feb 21, 2020

Conversation

fayyazarshad
Copy link
Contributor

Summary

to reduce package size, we are trying to gradually get rid of lodash library. This PR replaces isArray function with Array.isArray. Because lodash is also using this standard built-in objects from javascript.

Test plan

All tests pass after this change.

@fayyazarshad fayyazarshad self-assigned this Feb 18, 2020
@coveralls
Copy link
coveralls commented Feb 18, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.0003%) to 97.558% when pulling f5c6b67 on fayyaz/replace_lodash_isArray into ab7e371 on master.

@fayyazarshad fayyazarshad marked this pull request as ready for review February 18, 2020 07:53
@fayyazarshad fayyazarshad requested a review from a team as a code owner February 18, 2020 07:53
@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_isArray branch from b41334a to 2778f55 Compare February 19, 2020 06:28
mjc1283
mjc1283 suggested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor
@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find all usages of fns.isArray and replace with Array.isArray

@fayyazarshad fayyazarshad force-pushed the fayyaz/replace_lodash_isArray branch 2 times, most recently from 7c2e282 to dc78b0d Compare February 21, 2020 06:35
@mjc1283 mjc1283 merged commit d298f48 into master Feb 21, 2020
@mjc1283 mjc1283 deleted the fayyaz/replace_lodash_isArray branch February 21, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees

@fayyazarshad fayyazarshad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fayyazarshad @coveralls @mjc1283
0