[FSSDK-11330] update supported versions of platforms #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the platform support details by raising the minimum required Node.js version and upgrading related dependencies. Key changes include:
- Updating Node.js engine requirement from ">=14.0.0" to ">=18.0.0" in package.json.
- Upgrading the "uuid" library (and its type definitions) from version 9.x to 10.x.
- Updating the README to reflect the new ES6 target and Node.js version support.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated Node.js version, uuid dependency, and removed unused packages |
| README.md | Revised documentation to match updated platform support |
Comments suppressed due to low confidence (5)
package.json:138
- Confirm that the removal of ts-jest does not negatively impact the project's test setup and that an alternative testing configuration is in place if needed.
"ts-jest": "^29.1.2",
package.json:139
- Ensure that the removal of ts-mockito is intentional and that any tests relying on its mocking capabilities are updated or replaced accordingly.
"ts-mockito": "^2.6.1",
package.json:84
- Ensure that updating the Node.js engine requirement to >=18.0.0 is fully compatible with your production environments and deployment pipelines.
"node": ">=18.0.0"
package.json:97
- Review the uuid v10 update for any breaking changes to its API and confirm that the code consuming this library is updated accordingly.
"uuid": "^10.0.0"
README.md:34
- Verify that the shift from ES5 to ES6 in the documentation aligns with your broader compatibility strategy and that this change is clearly communicated to users.
Ensure the SDK supports all of the platforms you're targeting. In particular, the SDK targets modern ES6-compliant JavaScript environments.
9a88f07 to
089afb1
Compare
junaed-optimizely
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues