[FSSDK-11510] update retryConfig for batch event processor factories #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enforces a required maxRetries on retry configurations, updates the Node factory’s default retry count, and aligns related tests.
- Made
maxRetriesmandatory in factory option and retry config types - Changed default
maxRetriesfrom 10 to 5 in the Node-specific factory - Updated unit tests to reflect the new required
maxRetriesbehavior
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/event_processor/event_processor_factory.ts | Made retryOptions.maxRetries a required field |
| lib/event_processor/batch_event_processor.ts | Changed RetryConfig.maxRetries to be non-optional |
| lib/event_processor/event_processor_factory.node.ts | Adjusted default maxRetries from 10 down to 5 |
| lib/event_processor/event_processor_factory.spec.ts | Updated tests to pass explicit maxRetries |
| lib/event_processor/event_processor_factory.node.spec.ts | Aligned spec to expect 5 retries by default |
junaed-optimizely
approved these changes
May 16, 2025
There was a problem hiding this comment.
Please update copyright here!
There was a problem hiding this comment.
Please update copyright here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues