8000 [FSSDK-11448] Java Implementation: Add Experiment ID and Variation ID to Decision Notification by esrakartalOpt · Pull Request #566 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content
8000

[FSSDK-11448] Java Implementation: Add Experiment ID and Variation ID to Decision Notification #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 12, 2025
Merged

[FSSDK-11448] Java Implementation: Add Experiment ID and Variation ID to Decision Notification #566

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
66ecd7e
[FSSDK-11448] Java Implementation: Add Experiment ID and Variation ID…
esrakartalOpt May 1, 2025
4bf0e2a
Fix test
esrakartalOpt May 1, 2025
098f47a
Fix test
esrakartalOpt May 1, 2025
332b87f
Fix decision test
esrakartalOpt May 1, 2025
1b393cb
Fix test
esrakartalOpt May 5, 2025
05d7d81
Fix the tests
esrakartalOpt May 5, 2025
7ac8437
Fix test
esrakartalOpt May 5, 2025
295aacd
Fix last test case
esrakartalOpt May 5, 2025
d813b31
Fix the test case
esrakartalOpt May 5, 2025
7dc7c14
Remove experiment decision changes
esrakartalOpt May 9, 2025
e226329
Fix test
esrakartalOpt May 9, 2025
11f7daf
Fix test
esrakartalOpt May 9, 2025
d846544
Fix test
esrakartalOpt May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix decision test
  • Loading branch information
@esrakartalOpt
esrakartalOpt committed May 1, 2025
commit 332b87f48f327dc43a41a20fefc071794055c30c
8 changes: 7 additions & 1 deletion core-api/src/test/java/com/optimizely/ab/notification/DecisionNotificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ public class DecisionNotificationTest {

private static final Boolean FEATURE_ENABLED = Boolean.FALSE;
private static final String EXPERIMENT_KEY = "experimentKey";
private static final String EXPERIMENT_ID = "1234567";
private static final String FEATURE_KEY = "featureKey";
private static final String FEATURE_VARIABLE_KEY = "featureVariableKey";
private static final String FEATURE_TEST = "featureTest";
private static final String FEATURE_TEST_VARIATION = "featureTestVariation";
private static final String USER_ID = "userID";
private static final Map<String, String> USER_ATTRIBUTES = Collections.singletonMap("user", "attr");
private static final Variation VARIATION = mock(Variation.class);
private static final String VARIATION_ID = "1234567";

private FeatureTestSourceInfo featureTestSourceInfo;
private RolloutSourceInfo rolloutSourceInfo;
Expand All @@ -58,6 +60,8 @@ public void setUp() {
.withAttributes(USER_ATTRIBUTES)
.withExperimentKey(EXPERIMENT_KEY)
.withVariation(VARIATION)
.withExperimentId(EXPERIMENT_ID)
.withVariationId(VARIATION_ID)
.withType(NotificationCenter.DecisionNotificationType.AB_TEST.toString())
.build();
featureTestSourceInfo = new FeatureTestSourceInfo(FEATURE_TEST, FEATURE_TEST_VARIATION);
Expand Down Expand Up @@ -107,6 +111,8 @@ public void testGetDecisionInfo() {
HashMap<String, String> expectedExperimentDecisionInfo = new HashMap<>();
expectedExperimentDecisionInfo.put(Decision 7AB7 Notification.ExperimentDecisionNotificationBuilder.EXPERIMENT_KEY, EXPERIMENT_KEY);
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_KEY, VARIATION.getKey());
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.EXPERIMENT_ID, EXPERIMENT_ID);
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_ID, VARIATION_ID);
assertEquals(expectedExperimentDecisionInfo, experimentDecisionNotification.getDecisionInfo());

// Assert for Feature's DecisionInfo
Expand All @@ -128,7 +134,7 @@ public void testGetDecisionInfo() {

@Test
public void testToString() {
assertEquals("DecisionNotification{type='ab-test', userId='userID', attributes={user=attr}, decisionInfo={experimentKey=experimentKey, variationKey=null}}", experimentDecisionNotification.toString());
assertEquals("DecisionNotification{type='ab-test', userId='userID', attributes={user=attr}, decisionInfo={experimentKey=experimentKey, variationKey=null, experimentId='1234567', variationId='1234567'}}", experimentDecisionNotification.toString());
assertEquals("DecisionNotification{type='feature', userId='userID', attributes={user=attr}, decisionInfo={featureEnabled=false, sourceInfo={experimentKey=featureTest, variationKey=featureTestVariation}, source=feature-test, featureKey=featureKey}}", featureDecisionNotification.toString());
assertEquals("DecisionNotification{type='feature-variable', userId='userID', attributes={user=attr}, decisionInfo={variableType=string, featureEnabled=true, sourceInfo={}, variableValue=null, variableKey=featureVariableKey, source=rollout, featureKey=featureKey}}", featureVariableDecisionNotification.toString());
}
Expand Down
Loading
0