up

optimizely · raju-opti · Oct 22, 2024 · Oct 17, 2024 · Oct 17, 2024 · Oct 17, 2024
commit 56a041bf11e20b17d205c89e38e2755a6b9e071e
diff --git a/core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java b/core-api/src/main/java/com/optimizely/ab/bucketing/DecisionService.java
@@ -132,8 +132,7 @@ public DecisionResponse<Variation> getVariation(@Nonnull Experiment experiment,
 
             if (variation != null) {
                 if (userProfileTracker != null) {
-                    updateUserProfile(experiment, variation, userProfileTracker.userProfile);
-                    userProfileTracker.profileUpdated = true;
+                    userProfileTracker.updateUserProfile(experiment, variation);
                 } else {
                     logger.debug("This decision will not be saved since the UserProfileService is null.");
                 }
@@ -233,14 +232,32 @@ private UserProfile getUserProfile(String userId, DecisionReasons reasons) {
         return  userProfile;
     }
 
-    static class UserProfileTracker {
+    class UserProfileTracker {
         public UserProfile userProfile;
         public boolean profileUpdated;
 
         UserProfileTracker(UserProfile userProfile, boolean profileUpdated) {
             this.userProfile = userProfile;
             this.profileUpdated = profileUpdated;
         }
+
+        void updateUserProfile(@Nonnull Experiment experiment,
+                               @Nonnull Variation variation) {
+
+            String experimentId = experiment.getId();
+            String variationId = variation.getId();
+            Decision decision;
+            if (userProfile.experimentBucketMap.containsKey(experimentId)) {
+                decision = userProfile.experimentBucketMap.get(experimentId);
+                decision.variationId = variationId;
+            } else {
+                decision = new Decision(variationId);
+            }
+            userProfile.experimentBucketMap.put(experimentId, decision);
+            profileUpdated = true;
+            logger.info("Updated variation \"{}\" of experiment \"{}\" for user \"{}\".",
+                variationId, experimentId, userProfile.userId);
+        }
     }
 
     /**
@@ -495,31 +512,6 @@ DecisionResponse<Variation> getStoredVariation(@Nonnull Experiment experiment,
         }
     }
 
-    /**
-     * Save a {@link Variation} of an {@link Experiment} for a user in the {@link UserProfileService}.
-     *
-     * @param experiment  The experiment the user was buck
-     * @param variation   The Variation to save.
-     * @param userProfile A {@link UserProfile} instance of the user information.
-     */
-    void updateUserProfile(@Nonnull Experiment experiment,
-                       @Nonnull Variation variation,
-                       @Nonnull UserProfile userProfile) {
-
-        String experimentId = experiment.getId();
-        String variationId = variation.getId();
-        Decision decision;
-        if (userProfile.experimentBucketMap.containsKey(experimentId)) {
-            decision = userProfile.experimentBucketMap.get(experimentId);
-            decision.variationId = variationId;
-        } else {
-            decision = new Decision(variationId);
-        }
-        userProfile.experimentBucketMap.put(experimentId, decision);
-        logger.info("Updated variation \"{}\" of experiment \"{}\" for user \"{}\".",
-            variationId, experimentId, userProfile.userId);
-    }
-
     /**
      * Save a {@link Variation} of an {@link Experiment} for a user in the {@link UserProfileService}.
      *