8000 [FSSDK-9785] handle duplicate experiment keys with a warning by jaeopt · Pull Request #535 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9785] handle duplicate experiment keys with a warning #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[FSSDK-9785] handle duplicate experiment keys with a warning #535

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce9b415
add warning for duplicate experiment keys
jaeopt Nov 21, 2023
6a34e10
add test
jaeopt Nov 21, 2023
03d82e2
clean up
jaeopt Nov 21, 2023
ca2c18b
fix copyright
jaeopt Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@jaeopt
jaeopt committed Nov 21, 2023
commit 6a34e109a5838dda85329821d3ca7a47b00840d1
37 changes: 35 additions & 2 deletions core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,29 @@
***************************************************************************/
package com.optimizely.ab.optimizelyconfig;

import ch.qos.logback.classic.Level;
import com.optimizely.ab.config.*;
import com.optimizely.ab.config.audience.Audience;
import com.optimizely.ab.internal.LogbackVerifier;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.runners.MockitoJUnitRunner;

import java.util.*;
import static java.util.Arrays.asList;
import static org.junit.Assert.*;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class OptimizelyConfigServiceTest {

private ProjectConfig projectConfig;
private OptimizelyConfigService optimizelyConfigService;
private OptimizelyConfig expectedConfig;

@Rule
public LogbackVerifier logbackVerifier = new LogbackVerifier();

@Before
public void initialize() {
projectConfig = generateOptimizelyConfig();
Expand All @@ -46,6 +52,33 @@ public void testGetExperimentsMap() {
assertEquals(expectedConfig.getExperimentsMap(), optimizelyExperimentMap);
}

@Test
public void testGetExperimentsMapWithDuplicateKeys() {
List<Experiment> experiments = Arrays.asList(
new Experiment(
"first",
"duplicate_key",
null, null, Collections.<String>emptyList(), null,
Collections.<Variation>emptyList(), Collections.<String, String>emptyMap(), Collections.<TrafficAllocation>emptyList()
),
new Experiment(
"second",
"duplicate_key",
null, null, Collections.<String>emptyList(), null,
Collections.<Variation>emptyList(), Collections.<String, String>emptyMap(), Collections.<TrafficAllocation>emptyList()
)
);

ProjectConfig projectConfig = mock(ProjectConfig.class);
OptimizelyConfigService optimizelyConfigService = new OptimizelyConfigService(projectConfig);
when(projectConfig.getExperiments()).thenReturn(experiments);

Map<String, OptimizelyExperiment> optimizelyExperimentMap = optimizelyConfigService.getExperimentsMap();
assertEquals("Duplicate keys should be overwritten", optimizelyExperimentMap.size(), 1);
assertEquals("Duplicate keys should be overwritten", optimizelyExperimentMap.get("duplicate_key").getId(), "second");
logbackVerifier.expectMessage(Level.WARN, "Duplicate experiment keys found in datafile: duplicate_key");
}

@Test
public void testRevision() {
String revision = optimizelyConfigService.getConfig().getRevision();
Expand Down
0