8000 Mng/pr 361 by mikeproeng37 · Pull Request #365 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

Mng/pr 361 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Mng/pr 361 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d6976d
(fix) change log level to warn when experiment not in datafile
compass-vin Feb 26, 2020
0f54268
Fixed tests
alanhuu Feb 27, 2020
8b278d3
Merge branch 'master' into change-logging-error
compass-vin Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public Experiment getExperimentForKey(@Nonnull String experimentKey,
// if the given experiment key isn't present in the config, log an exception to the error handler
if (experiment == null) {
String unknownExperimentError = String.format("Experiment \"%s\" is not in the datafile.", experimentKey);
logger.error(unknownExperimentError);
logger.warn(unknownExperimentError);
errorHandler.handleError(new UnknownExperimentException(unknownExperimentError));
}

Expand All @@ -247,7 +247,7 @@ public EventType getEventTypeForName(String eventName, ErrorHandler errorHandler
// if the given event name isn't present in the config, log an exception to the error handler
if (eventType == null) {
String unknownEventTypeError = String.format("Event \"%s\" is not in the datafile.", eventName);
logger.error(unknownEventTypeError);
logger.warn(unknownEventTypeError);
errorHandler.handleError(new UnknownEventTypeException(unknownEventTypeError));
}

Expand Down
6 changes: 3 additions & 3 deletions core-api/src/test/java/com/optimizely/ab/O 8000 ptimizelyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ public void activateWithUnknownExperimentKeyAndNoOpErrorHandler() throws Excepti
Experiment unknownExperiment = createUnknownExperiment();
Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build();

logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile.");
logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile.");
logbackVerifier.expectMessage(Level.INFO,
"Not activating user \"userId\" for experiment \"unknown_experiment\".");

Expand Down Expand Up @@ -986,7 +986,7 @@ public void trackEventWithUnknownEventKeyAndNoOpErrorHandler() throws Exception

Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build();

logbackVerifier.expectMessage(Level.ERROR, "Event \"unknown_event_type\" is not in the datafile.");
logbackVerifier.expectMessage(Level.WARN, "Event \"unknown_event_type\" is not in the datafile.");
logbackVerifier.expectMessage(Level.INFO, "Not tracking event \"unknown_event_type\" for user \"userId\".");
optimizely.track(unknownEventType.getKey(), testUserId);
}
Expand Down Expand Up @@ -1333,7 +1333,7 @@ public void getVariationWithUnknownExperimentKeyAndNoOpErrorHandler() throws Exc
.withErrorHandler(new NoOpErrorHandler())
.build();

logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile.");
logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile.");

// since we use a NoOpErrorHandler, we should fail and return null
Variation actualVariation = optimizely.getVariation(unknownExperiment.getKey(), testUserId);
Expand Down
0