8000 [FSSDK-9862] Add OpenTelemetry Tracing support by pulak-opti · Pull Request #385 · optimizely/go-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9862] Add OpenTelemetry Tracing support #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 18, 2024
Merged

[FSSDK-9862] Add OpenTelemetry Tracing support #385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
da2c2b7
add tracing option in go-sdk
pulak-opti Dec 1, 2023
e9e5e79
add tracing for track event
pulak-opti Dec 1, 2023
3fc8057
update version
pulak-opti Dec 1, 2023
8cf34c2
update otel tracer
pulak-opti Dec 1, 2023
855ceaa
update sdk implementation
pulak-opti Dec 4, 2023
a8c4354
add comment
pulak-opti Jan 9, 2024
ab92186
add otel tracing
pulak-opti Jan 15, 2024
384109e
fix linter error
pulak-opti Jan 15, 2024
8593895
update otel dependency
pulak-opti Jan 16, 2024
8b3d53b
fix typo & update license header
pulak-opti Jan 16, 2024
ca038c0
update go version
pulak-opti Jan 16, 2024
e47be6b
use constant for tracer name
pulak-opti Jan 16, 2024
ee5d887
add unit tests
pulak-opti Jan 16, 2024
161d012
change otel tracing flow
pulak-opti Jan 17, 2024
03c9034
skip version update for FSC test
pulak-opti Jan 17, 2024
c9bc3e7
add WithTraceContext() method for OptimizelyUserContext struct
pulak-opti Jan 17, 2024
8000
46651cf
add unit tests
pulak-opti Jan 17, 2024
de3f057
add one more unit test
pulak-opti Jan 17, 2024
c3521dc
add review changes
pulak-opti Jan 17, 2024
5389def
fix linter
pulak-opti Jan 17, 2024
7b9cba0
remove WithTraceContext() for UserContext
pulak-opti Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update otel tracer
  • Loading branch information
@pulak-opti
pulak-opti committed Dec 1, 2023
commit 8cf34c2a8673b7355e96597c9e5793f7778e2bd5
3 changes: 3 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@ require (
require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/felixge/fgprof v0.9.3 // indirect
github.com/go-logr/logr v1.2.4 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/google/pprof v0.0.0-20211214055906-6f57359322fd // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/stretchr/objx v0.5.0 // indirect
go.opentelemetry.io/otel/metric v1.19.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
7 changes: 7 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/felixge/fgprof v0.9.3 h1:VvyZxILNuCiUCSXtPtYmmtGvb65nqXh2QFWc0Wpf2/g=
github.com/felixge/fgprof v0.9.3/go.mod h1:RdbpDgzqYVh/T9fPELJyV7EYJuHB55UTEULNun8eiPw=
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/logr v1.2.4 h1:g01GSCwiDw2xSZfjJ2/T9M+S6pFdcNtFYsp+Y43HYDQ=
github.com/go-logr/logr v1.2.4/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
Expand Down Expand Up @@ -45,6 +50,8 @@ github.com/twmb/murmur3 v1.1.6 h1:mqrRot1BRxm+Yct+vavLMou2/iJt0tNVTTC0QoIjaZg=
github.com/twmb/murmur3 v1.1.6/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
go.opentelemetry.io/otel v1.19.0 h1:MuS/TNf4/j4IXsZuJegVzI1cwut7Qc00344rgH7p8bs=
go.opentelemetry.io/otel v1.19.0/go.mod h1:i0QyjOq3UPoTzff0PJB2N66fb4S0+rSbSB15/oyH9fY=
go.opentelemetry.io/otel/metric v1.19.0 h1:aTzpGtV0ar9wlV4Sna9sdJyII5jTVJEvKETPiOKwvpE=
go.opentelemetry.io/otel/metric v1.19.0/go.mod h1:L5rUsV9kM1IxCj1MmSdS+JQAcVm319EUrDVLrt7jqt8=
go.opentelemetry.io/otel/trace v1.19.0 h1:DFVQmlVbfVeOuBRrwdtaehRrWiL1JoVs9CPIQ1Dzxpg=
go.opentelemetry.io/otel/trace v1.19.0/go.mod h1:mfaSyvGyEJEI0nyV2I4qhNQnbBOUUmYZpYojqMnX2vo=
golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o=
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ func (o *OptimizelyClient) Track(ctx context.Context, eventKey string, userConte
}()

// TODO: we need to change userContext to carry a context from the caller to use in StartSpan
_, span := o.tracer.StartSpan(ctx, "track-sdk")
_, span := o.tracer.StartSpan(ctx, "trackHandler", "trackSDK")
defer span.End()

projectConfig, e := o.getProjectConfig()
Expand Down
9 changes: 5 additions & 4 deletions pkg/tracing/opentelemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package tracing
import (
"context"

"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/trace"
)
Expand All @@ -28,7 +29,7 @@ func (s *otelSpan) End() {
}

type Tracer interface {
StartSpan(ctx context.Context, spanName string) (context.Context, Span)
StartSpan(ctx context.Context, tracerName, spanName string) (context.Context, Span)
}

type otelTracer struct {
Expand All @@ -41,16 +42,16 @@ func NewOtelTracer(t trace.Tracer) Tracer {
}
}

func (t *otelTracer) StartSpan(pctx context.Context, spanName string) (context.Context, Span) {
ctx, span := t.tracer.Start(pctx, spanName)
func (t *otelTracer) StartSpan(pctx context.Context, tracerName, spanName string) (context.Context, Span) {
ctx, span := otel.Tracer(tracerName).Start(pctx, spanName)
return ctx, &otelSpan{
span: span,
}
}

type NoopTracer struct{}

func (t *NoopTracer) StartSpan(ctx context.Context, spanName string) (context.Context, Span) {
func (t *NoopTracer) StartSpan(ctx context.Context, tracerName string, spanName string) (context.Context, Span) {
return ctx, &NoopSpan{}
}

Expand Down
0