10000 [FSSDK-9155] fix(ticker): stop all tickers to prevent goroutine leak by pulak-opti · Pull Request #375 · optimizely/go-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9155] fix(ticker): stop all tickers to prevent goroutine leak #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2023
Merged

[FSSDK-9155] fix(ticker): stop all tickers to prevent goroutine leak #375

merged 4 commits into from
May 15, 2023

Conversation

pulak-opti
Copy link
Contributor

Summary

  • Fix goroutine leak for ticker

Issues

@pulak-opti pulak-opti requested a review from a team as a code owner May 12, 2023 15:52
@pulak-opti pulak-opti changed the title fix(ticker): stop all tickers to prevent goroutine leak [FSSDK-9155] fix(ticker): stop all tickers to prevent goroutine leak May 12, 2023
yasirfolio3
yasirfolio3 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor
@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit suggestion, LGTM.

@pulak-opti pulak-opti marked this pull request as draft May 12, 2023 16:56
@pulak-opti pulak-opti marked this pull request as ready for review May 15, 2023 12:14
@pulak-opti pulak-opti merged commit 7ffed83 into master May 15, 2023
@pulak-opti pulak-opti deleted the pulak/fix-ticker branch May 15, 2023 12:16
@pulak-opti pulak-opti mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

Assignees

@pulak-opti pulak-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pulak-opti @yasirfolio3
0