8000 [FSSDK-9526] refact: Implements a warning log for polling interval less than 30s by mnoman09 · Pull Request #365 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9526] refact: Implements a warning log for polling interval less than 30s #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2023
Merged

[FSSDK-9526] refact: Implements a warning log for polling interval less than 30s #365

merged 5 commits into from
Aug 3, 2023

Conversation

mnoman09
Copy link
Contributor
@mnoman09 mnoman09 commented Aug 1, 2023

Summary

  • Implements a warning log for polling interval less than 30s

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner August 1, 2023 12:37
@mnoman09 mnoman09 removed their assignment Aug 1, 2023
mikechu-optimizely
mikechu-optimizely requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor
@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think.

@mnoman09 mnoman09 removed their assignment Aug 2, 2023
mikechu-optimizely
mikechu-optimizely approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor
@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope I didn't walk all over your code 😬

@mnoman09 mnoman09 merged commit f3a21d5 into master Aug 3, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9526 branch August 3, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mnoman09 mnoman09

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @mikechu-optimizely @NomanShoaib
0