8000 [FSSDK-9472] fix: Last-Modified header not respected by mikechu-optimizely · Pull Request #355 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9472] fix: Last-Modified header not respected #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2023
Merged

[FSSDK-9472] fix: Last-Modified header not respected #355

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
811c3b2
Fix where Last-Modified is pulled
mikechu-optimizely Jun 22, 2023
4ccda36
Corrected small problems in test class
mikechu-optimizely Jun 22, 2023
5780d06
WIP Adding Last Modified test
mikechu-optimizely Jun 22, 2023
a470f90
Add test coverage
mikechu-optimizely Jun 23, 2023
2743bd5
Fix failing test by deferring
mikechu-optimizely Jun 23, 2023
dd86360
Merge branch 'master' into mike/fix-last-modified
mikechu-optimizely Jun 23, 2023
9233d38
Lint fixes
mikechu-optimizely Jun 23, 2023
a5af695
Lint fix whitespace
mikechu-optimizely Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failing test by deferring
  • Loading branch information
@mikechu-optimizely
mikechu-optimizely committed Jun 23, 2023
commit 2743bd525404480ac34d0743b85e387ccfda4cdd
14 changes: 9 additions & 5 deletions OptimizelySDK.Tests/ConfigTest/HttpProjectConfigManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,26 +97,30 @@ public void TestSettingIfModifiedSinceInRequestHeader()
{
var t = MockSendAsync(
datafile: string.Empty,
statusCode: HttpStatusCode.NotModified
statusCode: HttpStatusCode.NotModified,
responseContentHeaders: new Dictionary<string, string>
{
{ "Last-Modified", new DateTime(2050, 10, 10).ToString("R") },
}
);

var httpManager = new HttpProjectConfigManager.Builder()
.WithDatafile(string.Empty)
.WithLogger(LoggerMock.Object)
.WithPollingInterval(TimeSpan.FromMilliseconds(1000))
.WithBlockingTimeoutPeriod(TimeSpan.FromMilliseconds(4000))
.WithBlockingTimeoutPeriod(TimeSpan.FromMilliseconds(2000))
.WithStartByDefault()
.Build();
.Build(defer: true);
httpManager.LastModifiedSince = new DateTime(2020, 4, 4).ToString("R");
t.Wait(5000);
t.Wait(3000);

LoggerMock.Verify(
_ => _.Log(LogLevel.DEBUG, "Set If-Modified-Since in request header."),
Times.AtLeastOnce);

httpManager.Dispose();
}

[Test]
public void TestSettingLastModifiedFromResponseHeader()
{
Expand Down
0