8000 Fix: ODP Event manager not consistent in triggering events. by mnoman09 · Pull Request #326 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]

Skip to content

Fix: ODP Event manager not consistent in triggering events. #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prev Previous commit
Next Next commit
nit fix
  • Loading branch information
NomanShoaib committed Feb 10, 2023
commit 9c8e5dfb5474f5e34e2fae7bf33dc4f479b6ab15
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/OdpEventManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ protected virtual void Run()
item = _eventQueue.Take();
Thread.Sleep(1); // TODO: need to figure out why this is allowing item to read shutdown signal.
}

if (item == null)
{
// null means no new events received and flush interval is over, dispatch whatever is in the batch.
Expand All @@ -173,7 +174,6 @@ protected virtual void Run()
_logger.Log(LogLevel.INFO, "Received shutdown signal.");
break;
}

else if (item == _flushSignal)
{
_logger.Log(LogLevel.DEBUG, "Received flush signal.");
Expand Down
0