Small refactors

optimizely · mikechu-optimizely · Dec 7, 2022 · Nov 23, 2022 · Nov 23, 2022 · Nov 28, 2022
commit dcafcee3e07a78595f681fd4040501d4b0d590ed
diff --git a/OptimizelySDK.Tests/OdpTests/OdpConfigTest.cs b/OptimizelySDK.Tests/OdpTests/OdpConfigTest.cs
@@ -82,10 +82,10 @@ public void ShouldNotEqualWithSegmentsWithNull()
         [Test]
         public void ShouldNotEqualIfCaseDifferenceInApiKey()
         {
-            const string caseDifferenceInFirstLetterOfApiKey = "urAp1k3Y";
-            ;
+            const string CASE_DIFFERENCE_IN_FIRST_LETTER_OF_API_KEY = "urAp1k3Y";
             var apiKeyCaseDifferentConfig =
-                new OdpConfig(caseDifferenceInFirstLetterOfApiKey, API_HOST, segmentsToCheck);
+                new OdpConfig(CASE_DIFFERENCE_IN_FIRST_LETTER_OF_API_KEY, API_HOST,
+                    segmentsToCheck);
 
             Assert.IsFalse(_goodOdpConfig.Equals(apiKeyCaseDifferentConfig));
             Assert.IsFalse(apiKeyCaseDifferentConfig.Equals(_goodOdpConfig));

diff --git a/OptimizelySDK/Odp/OdpManager.cs b/OptimizelySDK/Odp/OdpManager.cs
@@ -148,24 +148,6 @@ Dictionary<string, object> data
             EventManager.SendEvent(new OdpEvent(type, action, identifiers, data));
         }
 
-        /// <summary>
-        /// Determines if the EventManager is ready to be used
-        /// </summary>
-        /// <returns>True if EventManager can process events otherwise False</returns>
-        private bool EventManagerOrConfigNotReady()
-        {
-            return EventManager == null || !_enabled || !_odpConfig.IsReady();
-        }
-
-        /// <summary>
-        /// Determines if the SegmentManager is ready to be used
-        /// </summary>
-        /// <returns>True if SegmentManager can fetch audience segments otherwise False</returns>
-        private bool SegmentManagerOrConfigNotReady()
-        {
-            return SegmentManager == null || !_enabled || !_odpConfig.IsReady();
-        }
-
         /// <summary>
         /// Sends signal to stop Event Manager and clean up ODP Manager use
         /// </summary>
@@ -292,5 +274,23 @@ public OdpManager Build(bool asEnabled = true)
                 return manager;
             }
         }
+
+        /// <summary>
+        /// Determines if the EventManager is ready to be used
+        /// </summary>
+        /// <returns>True if EventManager can process events otherwise False</returns>
+        private bool EventManagerOrConfigNotReady()
+        {
+            return EventManager == null || !_enabled || !_odpConfig.IsReady();
+        }
+
+        /// <summary>
+        /// Determines if the SegmentManager is ready to be used
+        /// </summary>
+        /// <returns>True if SegmentManager can fetch audience segments otherwise False</returns>
+        private bool SegmentManagerOrConfigNotReady()
+        {
+            return SegmentManager == null || !_enabled || !_odpConfig.IsReady();
+        }
     }
 }