8000 feat: Add ODP GraphQL Manager and Tests by mikechu-optimizely · Pull Request #310 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

feat: Add ODP GraphQL Manager and Tests #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 24, 2022
Merged

feat: Add ODP GraphQL Manager and Tests #310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
f7e0138
Initial GraphQLManager tests
mikechu-optimizely Aug 3, 2022
4536719
Correct GraphQLManagerTest.cs
mikechu-optimizely Aug 3, 2022
f2b4e79
Add GraphQL manager and supporting entities
mikechu-optimizely Aug 3, 2022
1e579ee
Fully cover json response
mikechu-optimizely Aug 3, 2022
d2df4a0
Adding GQLManager interface for testing
mikechu-optimizely Aug 3, 2022
368817f
Tests for common scenarios Swift ref
mikechu-optimizely Aug 3, 2022
728e1a8
Fix compiler error
mikechu-optimizely Aug 3, 2022
5e08827
Refactors
mikechu-optimizely Aug 3, 2022
5909f8e
WIP Handle versions of .NET
mikechu-optimizely Aug 3, 2022
7d35390
Merge branch 'master' into mike/ats-graphql
mikechu-optimizely Aug 4, 2022
5664b75
WebRequest and HttpClient ODP clients
mikechu-optimizely Aug 4, 2022
0e96ee1
Only support NET Standard; Inject & unit test
mikechu-optimizely Aug 4, 2022
3b267f3
Filled unit tests
mikechu-optimizely Aug 4, 2022
ed3f049
Copyright notices and ending line
mikechu-optimizely Aug 4, 2022
06a61a5
Corrections and simplifications
mikechu-optimizely Aug 5, 2022
705ce61
Corrections logged messages & supporting tests
mikechu-optimizely Aug 8, 2022
9a7ef8f
Remove excess validations
mikechu-optimizely Aug 8, 2022
dd91fce
Add unexpected node; Fix test
mikechu-optimizely Aug 8, 2022
8000
96b84fa
Update OptimizelySDK.Tests/OdpTests/GraphQLManagerTest.cs
mikechu-optimizely Aug 8, 2022
0f444df
Update OptimizelySDK/Odp/Client/OdpClient.cs
mikechu-optimizely Aug 8, 2022
8c74e43
Update OptimizelySDK/Odp/Client/OdpClient.cs
mikechu-optimizely Aug 8, 2022
6866c82
Enhanced error handling and matching tests
mikechu-optimizely Aug 8, 2022
2b2b65d
Add end of file lines
mikechu-optimizely Aug 8, 2022
cd4e8f1
Add class internal documentation
mikechu-optimizely Aug 16, 2022
d58e683
Add line at EOF
mikechu-optimizely Aug 16, 2022
0ef9849
Merge branch 'master' into mike/ats-graphql
mikechu-optimizely Aug 17, 2022
85b9fd3
Refactoring GraphQLManager
mikechu-optimizely Aug 18, 2022
f87d7f7
Refactor OdpClient
mikechu-optimizely Aug 18, 2022
c443b52
WIP Code review edits
mikechu-optimizely Aug 22, 2022
f57b438
Update doc
mikechu-optimizely Aug 22, 2022
98ad25d
QuerySegmentsParameters Builder
mikechu-optimizely Aug 23, 2022
2d76e3b
Documentation
mikechu-optimizely Aug 23, 2022
20016f9
Document constructors
mikechu-optimizely Aug 23, 2022
76e3e9e
Code review changes
mikechu-optimizely Aug 23, 2022
f5fc257
Adjust sync-to-async call methodology
mikechu-optimizely Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Prev Previous commit
Next Next commit
Refactors
  • Loading branch information
@mikechu-optimizely
mikechu-optimizely committed Aug 3, 2022
commit 5e088272a2e8d7a50aa7e01f6326f9059f9b5fac
4 changes: 2 additions & 2 deletions OptimizelySDK.Tests/OdpTests/GraphQLManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public void ShouldParseSuccessfulResponse()

var manager = new GraphQLManager(MockLogger.Object);

var response = manager.ParseResponse(responseJson);
var response = manager.ParseJson(responseJson);

Assert.IsNull(response.Errors);
Assert.IsNotNull(response.Data);
Expand Down Expand Up @@ -99,7 +99,7 @@ public void ShouldParseErrorResponse()

var manager = new GraphQLManager(MockLogger.Object);

var response = manager.ParseResponse(responseJson);
var response = manager.ParseJson(responseJson);

Assert.IsNull(response.Data.Customer);
Assert.IsNotNull(response.Errors);
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Audience.cs → OptimizelySDK/Odp/Entity/Audience.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Audience
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Customer.cs → OptimizelySDK/Odp/Entity/Customer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Customer
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Data.cs → OptimizelySDK/Odp/Entity/Data.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Data
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Edge.cs → OptimizelySDK/Odp/Entity/Edge.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Edge
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Error.cs → OptimizelySDK/Odp/Entity/Error.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Error
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Extension.cs → OptimizelySDK/Odp/Entity/Extension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Extension
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Location.cs → OptimizelySDK/Odp/Entity/Location.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Location
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Node.cs → OptimizelySDK/Odp/Entity/Node.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Node
{
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK/Odp/Entities/Response.cs → OptimizelySDK/Odp/Entity/Response.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace OptimizelySDK.Odp.Entities
namespace OptimizelySDK.Odp.Entity
{
public class Response
{
Expand Down
14 changes: 8 additions & 6 deletions OptimizelySDK/Odp/GraphQLManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using OptimizelySDK.Logger;
using OptimizelySDK.Odp.Entities;
using OptimizelySDK.Odp.Entity;
using System.Collections.Generic;
using System.Text.RegularExpressions;

Expand All @@ -15,16 +15,18 @@ public GraphQLManager(ILogger logger)
Logger = logger;
}

public Response ParseResponse(string jsonResponse)
public string[] FetchSegments(string apiKey, string apiHost, string userKey, string userValue, List<string> segmentToCheck)
{

return new string[0];
}

public Response ParseJson(string jsonResponse)
{
var json = Regex.Replace(jsonResponse, @"\s+", string.Empty);

return JsonConvert.DeserializeObject<Response>(json);
}

public string FetchSegments(string apiKey, string apiHost, string userKey, string userValue, List<string> segmentToCheck)
{
return string.Empty;
}
}
}
7 changes: 4 additions & 3 deletions OptimizelySDK/Odp/IGraphQLManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
using OptimizelySDK.Odp.Entities;
using OptimizelySDK.Odp.Entity;
using System.Collections.Generic;

namespace OptimizelySDK.Odp
{
public interface IGraphQLManager
{
Response ParseResponse(string jsonResponse);
string FetchSegments(string apiKey, string apiHost, string userKey, string userValue,
string[] FetchSegments(string apiKey, string apiHost, string userKey, string userValue,
List<string> segmentToCheck
);

Response ParseJson(string jsonResponse);
}
}
21 changes: 12 additions & 9 deletions OptimizelySDK/OptimizelySDK.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,15 @@
<Compile Include="Entity\Group.cs" />
<Compile Include="Entity\IdKeyEntity.cs" />
<Compile Include="Event\Entity\DecisionMetadata.cs" />
<Compile Include="Odp\Entities\Audience.cs" />
<Compile Include="Odp\Entities\Customer.cs" />
<Compile Include="Odp\Entities\Data.cs" />
<Compile Include="Odp\Entities\Edge.cs" />
<Compile Include="Odp\Entities\Error.cs" />
<Compile Include="Odp\Entities\Location.cs" />
<Compile Include="Odp\Entities\Extension.cs" />
<Compile Include="Odp\Entities\Node.cs" />
<Compile Include="Odp\Entities\Response.cs" />
<Compile Include="Odp\Entity\Audience.cs" />
<Compile Include="Odp\Entity\Customer.cs" />
<Compile Include="Odp\Entity\Data.cs" />
<Compile Include="Odp\Entity\Edge.cs" />
<Compile Include="Odp\Entity\Error.cs" />
<Compile Include="Odp\Entity\Location.cs" />
<Compile Include="Odp\Entity\Extension.cs" />
<Compile Include="Odp\Entity\Node.cs" />
<Compile Include="Odp\Entity\Response.cs" />
<Compile Include="Odp\GraphQLManager.cs" />
<Compile Include="Odp\IGraphQLManager.cs" />
<Compile Include="OptimizelyDecisions\DecisionMessage.cs" />
Expand Down Expand Up @@ -185,6 +185,9 @@
<ItemGroup>
<None Include="packages.config" />
</ItemGroup>
<ItemGroup>
<Folder Include="Odp\Client" />
</ItemGroup>
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
Expand Down
0