move validate forced decision to decision service #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
commented
Dec 21, 2021
| /// <param name="context">Object containing flag and rule key of which forced decision is set.</param> | ||
| /// <param name="flagDecision">Object containing forced decision based on the provided context.</param> | ||
| /// <param name="config">The Project config.</param> | ||
| /// <returns>A result with the variation</returns> |
There was a problem hiding this comment.
Need to revise parameters.
jaeopt
requested changes
Dec 22, 2021
| /// <param name="flagDecision">Object containing forced decision based on the provided context.</param> | ||
| /// <param name="config">The Project config.</param> | ||
| /// <returns>A result with the variation</returns> | ||
| public Result<Variation> ValidatedForcedDecision(OptimizelyDecisionContext context, OptimizelyForcedDecision forcedDecision, ProjectConfig config, string userId) |
There was a problem hiding this comment.
What about passing userContext. This can be simpler and extensible with usercontext?
Suggested change
| public Result<Variation> ValidatedForcedDecision(OptimizelyDecisionContext context, OptimizelyForcedDecision forcedDecision, ProjectConfig config, string userId) | |
| public Result<Variation> ValidatedForcedDecision(OptimizelyDecisionContext context, OptimizelyUserContext user, ProjectConfig config) |
| @@ -289,16 +289,18 @@ public void TestGetForcedDecisionReturnsValueWithRuleKey() | |||
| [Test] | |||
| public void TestFindValidatedForcedDecisionReturnsCorrectDecisionWithNullVariation() | |||
| { | |||
| var decisionReasons = new DecisionReasons(); | |||
There was a problem hiding this comment.
I believe this test will be moved to DecisionService.
dustin-sier
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
All unit test and FSC tests should pass.