-
Notifications
You must be signed in to change notification settings - Fork 20
feat(ForcedDecisions): add forced-decisions APIs to OptimizelyUserContext #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking &ld 10000 quo;Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Refactored and resolved comments given on PR * some suggested code. * unit test fixes. * typo fix * Removed getVariationFromExperiment as it was extra loop fixed some bugs and other minor issue due to which tests were failing * Added forcedDecisionStore class * more refactoring. * refactored Code * refactored and removed commented code * Added forcedDecisionStoreTests * conditional copy. * Fixed soure rollout issue * comment fixed. Co-authored-by: Sohail Hussain <mirza.sohailhussain@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we still need a few changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple suggestions in addition to Jae's comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good. A couple of more changes suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Add a set of new APIs for forced-decisions to OptimizelyUserContext:
Test plan