8000 [FSSDK-11076] chore: remove travis details from doc by muzahidul-opti · Pull Request #505 · optimizely/android-sdk · GitHub
[go: up one dir, main page]

Skip to content

[FSSDK-11076] chore: remove travis details from doc #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update yml
  • Loading branch information
muzahidul-opti committed Feb 17, 2025
commit 34c9da2ebac33f2c68d834448925f7ed8cffb2d9
15 changes: 6 additions & 9 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ jobs:
with:
# You should create a personal access token and store it in your repository
token: ${{ secrets.CI_USER_TOKEN }}
repository: 'optimizely/travisci-tools'
path: 'home/runner/travisci-tools'
repository: 'optimizely/ci-helper-tools'
path: 'home/runner/ci-helper-tools'
ref: 'master'

- name: set SDK Branch if PR
Expand All @@ -45 8000 ,14 +45,12 @@ jobs:
if: ${{ github.event_name == 'pull_request' }}
run: |
echo "SDK_BRANCH=$HEAD_REF" >> $GITHUB_ENV
echo "TRAVIS_BRANCH=$HEAD_REF" >> $GITHUB_ENV
- name: set SDK Branch if not pull request
env:
REF_NAME: ${{github.ref_name}}
if: ${{ github.event_name != 'pull_request' }}
run: |
echo "SDK_BRANCH=$REF_NAME" >> $GITHUB_ENV
echo "TRAVIS_BRANCH=$REF_NAME" >> $GITHUB_ENV
- name: Trigger build
env:
SDK: android
Expand All @@ -68,14 +66,13 @@ jobs:
PULL_REQUEST_SHA: ${{ github.event.pull_request.head.sha }}
PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
UPSTREAM_SHA: ${{ github.sha }}
TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
EVENT_MESSAGE: ${{ github.event.message }}
HOME: 'home/runner'
run: |
echo "$GITHUB_CONTEXT"
home/runner/travisci-tools/trigger-script-with-status-update.sh
home/runner/ci-helper-tools/trigger-script-with-status-update.sh
build:
uses: optimizely/android-sdk/.github/workflows/build.yml@master
uses: optimizely/android-sdk/.github/workflows/build.yml@muzahid/remove-travis
with:
action: build
test:
Expand Down Expand Up @@ -141,7 +138,7 @@ jobs:
uses: optimizely/android-sdk/.github/workflows/build.yml@master
with:
action: ship
travis_tag: ${GITHUB_REF#refs/*/}
github_tag: ${GITHUB_REF#refs/*/}
secrets:
MAVEN_SIGNING_KEY_BASE64: ${{ secrets.MAVEN_SIGNING_KEY_BASE64 }}
MAVEN_SIGNING_PASSPHRASE: ${{ secrets.MAVEN_SIGNING_PASSPHRASE }}
Expand All @@ -153,7 +150,7 @@ jobs:
uses: optimizely/android-sdk/.github/workflows/build.yml@master
with:
action: ship
travis_tag: BB-SNAPSHOT
github_tag: BB-SNAPSHOT
secrets:
MAVEN_SIGNING_KEY_BASE64: ${{ secrets.MAVEN_SIGNING_KEY_BASE64 }}
MAVEN_SIGNING_PASSPHRASE: ${{ secrets.MAVEN_SIGNING_PASSPHRASE }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
action:
required: true
type: string
travis_tag:
github_tag:
required: false
type: string
secrets:
Expand Down Expand Up @@ -39,4 +39,4 @@ jobs:
MAVEN_SIGNING_PASSPHRASE: ${{ secrets.MAVEN_SIGNING_PASSPHRASE }}
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
run: TRAVIS_TAG=${{ inputs.travis_tag }} ./gradlew ${{ inputs.action }}
run: github_tag=${{ inputs.github_tag }} ./gradlew ${{ inputs.action }}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We welcome contributions and feedback! All contributors must sign our [Contribut
7. Open a pull request from `YOUR_NAME/branch_name` to `master`.
8. A repository maintainer will review your pull request and, if all goes well, squash and merge it!

All branches will be built and run against the entire test suite on Travis with every commit.
All branches will be built and run against the entire test suite on Gtihub Actions with every commit.

The `test-app` module is built against a real Optimizely project. Changing the project ID will cause tests to fail. The test app should be used as a reference.

Expand Down
0