chore: removed travis yml and added git action support #411
Conversation
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| api-level: [21, 25, 26, 29] |
There was a problem hiding this comment.
I understand that github has an issue supporting AVD 31+.
Can we change "compile_sdk_version" to 31 (no need for "target_sdk_version") since it's required to run other fix?
There was a problem hiding this comment.
Yes I think we can change android compile sdk version to 31 it should cause no problem. As we already tested that on PR #406
| - uses: actions/checkout@v2 | ||
| - name: set up JDK 11 | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'temurin' | ||
| cache: gradle |
There was a problem hiding this comment.
These steps are repeated for all tasks. Just wondering if we can factor out as a function to simplify this workflow file. github needs to improve it :)
There was a problem hiding this comment.
Sure we can refactor it and move to seperate yaml then use it as uses. As of right now I don't there is any way to reuse the steps by keeping it in same file.
There was a problem hiding this comment.
I think with current implementation it is difficult to add reusable workflow so can we refactor it later if possible?
There was a problem hiding this comment.
@mnoman09 Can you just change compile_sdk_version to 31 and then we can merge it.
This reverts commit 9018e4d.
Summary
Test plan
All tests should pass