8000 feat(website): add raw json text to the manual installation option by favoyang · Pull Request #2522 · openupm/openupm · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add raw json text to the manual installation option #2522

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

favoyang
Copy link
Member
@favoyang favoyang commented Oct 7, 2021

Refs #1705

@favoyang favoyang merged commit f51c8a0 into master Oct 7, 2021
@favoyang favoyang deleted the feat/manual-install-raw-json branch October 7, 2021 03:24
@github-actions
Copy link
github-actions bot commented Oct 7, 2021

🎉 This PR is included in version 1.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hybridherbst
Copy link
Contributor

@favoyang some comments:

  • would change the registry name to OpenUPM, the URL there is redundant
  • great to see that the scope takes dependencies into account!
  • the installer is gone, I assume that's on purpose and that time has finally come?

@favoyang
Copy link
Member Author
favoyang commented Oct 7, 2021

would change the registry name to OpenUPM, the URL there is redundant

This is intended to keep consistent with openupm-cli. The openupm-cli can accept any registry, and use the domain name as the registry name.

the installer is gone, I assume that's on purpose and that time has finally come?

Yes. With #1705 completed the installer is gone as planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0