8000 CONSOLE-4615: Update DefaultList to use ResourceDataView by rhamilto · Pull Request #15560 · openshift/console · GitHub
[go: up one dir, main page]
Skip to content

CONSOLE-4615: Update DefaultList to use ResourceDataView #15560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

CONSOLE-4615: Update DefaultList to use ResourceDataView #15560

wants to merge 11 commits into from
+1,635 −1,064

Conversation

rhamilto
Copy link
Member
@rhamilto rhamilto commented Oct 2, 2025 •
edited
Loading

Includes changes from #15492, which should merge first.

Note now that we have tables with horizontal scrolling, the limit of 3 additional printer columns has been removed and we display all (demonstrated in the SecurityContextConstraints list).

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor
openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from https://github.com/openshift/console/pull/15492/files#diff-462b6630c494b9ed11ced9c76d39113638cbec98b8f148927b7838343b4836fe

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig October 2, 2025 18:33
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Oct 2, 2025
@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 2, 2025
@openshift-ci-robot
Copy link
Contributor
openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from https://github.com/openshift/console/pull/15492/files#diff-462b6630c494b9ed11ced9c76d39113638cbec98b8f148927b7838343b4836fe

Note now that we have tables with horizontal scrolling, the limit of 3 additional printer columns has been removed and we display all.

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor
openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from https://github.com/openshift/console/pull/15492/files#diff-462b6630c494b9ed11ced9c76d39113638cbec98b8f148927b7838343b4836fe

Note now that we have tables with horizontal scrolling, the limit of 3 additional printer columns has been removed and we display all (demonstrated in the SecurityContextConstraints list).

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author
rhamilto commented Oct 3, 2025

/retest

1 similar comment
@rhamilto
Copy link
Member Author
rhamilto commented Oct 3, 2025

/retest

@rhamilto
Copy link
Member Author
rhamilto commented Oct 6, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 6, 2025
Open
@rhamilto
Copy link
Member Author
rhamilto commented Oct 7, 2025

/retest

2 similar comments
@rhamilto
Copy link
Member Author
rhamilto commented Oct 7, 2025

/retest

@rhamilto
Copy link
Member Author
rhamilto commented Oct 7, 2025

/retest

@rhamilto rhamilto mentioned this pull request Oct 7, 2025
Open
@rhamilto
Copy link
Member Author
rhamilto commented Oct 8, 2025

/retest

@rhamilto
Copy link
Member Author
rhamilto commented Oct 8, 2025

/retest

@rhamilto
Copy link
Member Author
rhamilto commented Oct 9, 2025

/retest

@rhamilto rhamilto closed this Oct 9, 2025
@rhamilto rhamilto reopened this Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor
openshift-ci-robot commented Oct 9, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from https://github.com/openshift/console/pull/15492/files#diff-462b6630c494b9ed11ced9c76d39113638cbec98b8f148927b7838343b4836fe

Note now that we have tables with horizontal scrolling, the limit of 3 additional printer columns has been removed and we display all (demonstrated in the SecurityContextConstraints list).

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

628C
@openshift-ci-robot
Copy link
Contributor
openshift-ci-robot commented Oct 9, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4615 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Includes changes from #15492, which should merge first.

Note now that we have tables with horizontal scrolling, the limit of 3 additional printer columns has been removed and we display all (demonstrated in the SecurityContextConstraints list).

Screen.Recording.2025-10-02.at.2.31.05.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author
rhamilto commented Oct 9, 2025

code approval:
/assign @TheRealJon
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Oct 9, 2025

@rhamilto: GitHub didn't allow me to assign the following users: jseseCCS.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

code approval:
/assign @TheRealJon
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto
Copy link
Member Author
rhamilto commented Oct 9, 2025

/retest

@rhamilto
Copy link
Member Author
rhamilto commented Oct 9, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor
openshift-ci bot commented Oct 10, 2025

@rhamilto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 43ba551 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@sferich888 sferich888

@yapei yapei

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @sferich888 @yapei @TheRealJon
0