8000 fix: handle monorepo caching by ascorbic · Pull Request #538 · opennextjs/opennextjs-netlify · GitHub
[go: up one dir, main page]
Skip to content

fix: handle monorepo caching #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2021
Merged

fix: handle monorepo caching #538

merged 2 commits into from
Jul 19, 2021

Conversation

ascorbic
Copy link
Contributor

When caching a build, the distDir wasn't being found in monorepos, because it wasn't accounting for nextRoot. This PR ensures that nextRoot is used.

Fixes #500

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jul 19, 2021
@ascorbic ascorbic requested a review from lindsaylevine July 19, 2021 10:00
lindsaylevine
lindsaylevine approved these changes Jul 19, 2021
View reviewed changes
Copy link
@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowee

@ascorbic ascorbic force-pushed the fix/monorepo-cache branch from d96c923 to 0c7cabc Compare July 19, 2021 10:51
@ascorbic ascorbic requested a review from lindsaylevine July 19, 2021 11:00
lindsaylevine
lindsaylevine approved these changes Jul 19, 2021
View reviewed changes
Copy link
@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the tests better lolz

@ascorbic ascorbic merged commit 9477e0e into main Jul 19, 2021
@ascorbic ascorbic deleted the fix/monorepo-cache branch July 19, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsaylevine lindsaylevine lindsaylevine approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monorepo: Cache Support
2 participants
@ascorbic @lindsaylevine
0