feat!: switch function bundling to esbuild #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e42a618 to
ef0e319
Compare
ef0e319 to
1316b77
Compare
Closed
Merged
serhalp
pushed a commit
that referenced
this pull request
Jun 13, 2024
* chore: renamed test * chore: handle experimental react in test fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches generated functions to use esbuild. This gives significant improvements in bundling time. This requires the latest version of the CLI, so it is a breaking change and we add a check for this.
In order to force the functions to use esbuild we switch them to be in TypeScript. This is because config mutation for bundling isn't fully supported in the CLI, and TypeScript always triggers the use of esbuild.
At the same time, I've simplified the wrapper, moving the helpers into a single file, and generating the entry point dynamically so that it includes the full import to the page.