8000 fix: fix bug that caused ISR pages to sometimes serve first built version by ascorbic · Pull Request #1051 · opennextjs/opennextjs-netlify · GitHub
[go: up one dir, main page]
Skip to content

fix: fix bug that caused ISR pages to sometimes serve first built version #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2021
Merged

fix: fix bug that caused ISR pages to sometimes serve first built version #1051

merged 2 commits into from
Dec 21, 2021

Conversation

ascorbic
Copy link
Contributor
@ascorbic ascorbic commented Dec 21, 2021 •
edited
Loading

Summary

An env var flag was left in the release version which was handling the Next server patching.

Test plan

  • Load deploy preview
  • Check displayed build time
  • Wait 1 minute, load again. Time may be the same. It it has updated, then it was already refreshed. If not move to next step.
  • Wait another minute, then load again. Time should have updated.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

It's time for the capybaras' annual yuzu onsen

image

Fixes #1028. Fixes #1035

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link
netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 5861107

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61c1b3a95df4df0008462570

😎 Browse the preview: https://deploy-preview-1051--netlify-plugin-nextjs-demo.netlify.app

@netlify
Copy link
netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: 5861107

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61c1b3a9724e1100071484af

😎 Browse the preview: https://deploy-preview-1051--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Dec 21, 2021
@netlify
Copy link
netlify bot commented •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: 5861107

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61c1b3a91b4be9000894fd8d

😎 Browse the preview: https://deploy-preview-1051--netlify-plugin-nextjs-static-root-demo.netlify.app

@netlify
Copy link
netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

🔨 Explore the source changes: 5861107

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61c1b3a90e00f30008276297

😎 Browse the preview: https://deploy-preview-1051--netlify-plugin-nextjs-export-demo.netlify.app

@cypress
Copy link
cypress bot commented Dec 21, 2021 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit 5861107
Started Dec 21, 2021 11:02 AM
Ended Dec 21, 2021 11:03 AM
Duration 01:09 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link
cypress bot commented Dec 21, 2021 •
edited
Loading


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit 5861107
Started Dec 21, 2021 11:02 AM
Ended Dec 21, 2021 11:03 AM
Duration 01:20 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link
cypress bot commented Dec 21, 2021


Test summary

16 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit 937e6e5
Started Dec 21, 2021 10:38 AM
Ended Dec 21, 2021 10:40 AM
Duration 02:17 💡
OS Linux Ubuntu - 20.04
Browser Custom chromium 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kodiakhq kodiakhq bot merged commit 62660b2 into main Dec 21, 2021
@kodiakhq kodiakhq bot deleted the mk/patch-isr-flag branch December 21, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ISR not working when my web app deployed [Bug]: ISR not working as expected
2 participants
@ascorbic @eduardoboucas
0