8000 refactor: patch NextServer#getMiddlewareManifest for Next >= 14 by vicb · Pull Request #892 · opennextjs/opennextjs-aws · GitHub
[go: up one dir, main page]
Skip to content

refactor: patch NextServer#getMiddlewareManifest for Next >= 14 #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

refactor: patch NextServer#getMiddlewareManifest for Next >= 14 #892

merged 2 commits into from
Jun 6, 2025

Conversation

vicb
Copy link
Contributor
@vicb vicb commented Jun 5, 2025 •
edited
Loading

In Cloudflare we inline the middleware manifest but that is not needed.

If we patch getMiddlewareManifest for version >= 14 then we could skip the pacth in Cloudflare and just rely on return null;

Dropping the patch in cloudflare would not work with Next.js 14 as the patch is only applied for Next 15

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9c743c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 5, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.99% 2620 / 9706
🔵 Statements 26.99% 2620 / 9706
🔵 Functions 53.1% 137 / 258
🔵 Branches 73.3% 615 / 839
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/patch/patches/patchNextServer.ts 100% 100% 100% 100%
Generated in workflow #1301 for commit 9c743c4 by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Jun 5, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@892

commit: 9c743c4

@vicb vicb requested a review from conico974 June 5, 2025 18:56
@vicb vicb mentioned this pull request Jun 5, 2025
Open
1 task
@sommeeeer
Copy link
Contributor
sommeeeer commented Jun 6, 2025 •
edited
Loading

I think you can drop that minimalRule aswell? Since runEdgeFunction and runMiddleware is emptied in the dropBabel patch? You could most likely do the same with the imageOptimizer there to be consistent.

@vicb
Copy link
Contributor Author
vicb commented Jun 6, 2025

I think you can drop that minimalRule aswell? Since runEdgeFunction and runMiddleware is emptied in the dropBabel patch? You could most likely do the same with the imageOptimizer there to be consistent.

Good point.

I'll create a distinct PR for that for tracking purposes

@sommeeeer
Copy link
Contributor

What about hasMiddleware and loadNodeMiddleware?

@vicb
Copy link
Contributor Author
vicb commented Jun 6, 2025

What about hasMiddleware and loadNodeMiddleware?

It doesn't look like they pulls deps?
So while we could probably empty their body, there wouldn't be much gain?

@vicb vicb force-pushed the vicb/next-server-middleware branch from ea95c2c to 9c743c4 Compare June 6, 2025 12:42
@vicb vicb requested a review from conico974 June 6, 2025 12:42
@vicb vicb changed the title refactor: patch NextServer#getMiddlewareManifest regardless of Next version refactor: patch NextServer#getMiddlewareManifest for Next >= 14 Jun 6, 2025
conico974
conico974 approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor
@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vicb vicb merged commit 0e25eb1 into main Jun 6, 2025
3 checks passed
@vicb vicb deleted the vicb/next-server-middleware branch June 6, 2025 15:42
@vicb
Copy link
Contributor Author
vicb commented Jun 6, 2025

Thanks Nico!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @sommeeeer @conico974
0