You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cloudflare adapter, we want to copy files used via the "workerd" build conditions.
To be able to do this this PR updates copyTracedFiles to return a map of traced node packages.
It maps the original path of the package to the path in .open-next.
As a follow up, we might integrate that better with the patch system.
Today, applyCodePatches assumes that a patch will update file content.
We could modify applyCodePatches to take a list of Patch.
The Patch class would be instantiated with options, tracedFiles, manifests, nodePackages, nextVersion and have a public apply method.
We could then have derived PatchFileContent, PatchCopyFile, ... classes.
As a follow up, we might integrate that better with the patch system.
Today, applyCodePatches assumes that a patch will update file content.
We could modify applyCodePatches to take a list of Patch.
The Patch class would be instantiated with options, tracedFiles, manifests, nodePackages, nextVersion and have a public apply method.
We could then have derived PatchFileContent, PatchCopyFile, ... classes.
That's a good idea yeah.
One other improvements that would be great to have would be for ast-grep to avoid parsing the same files multiple times, (but i think it involves changes in ast-grep itself)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the cloudflare adapter, we want to copy files used via the "workerd" build conditions.
To be able to do this this PR updates
copyTracedFilesto return a map of traced node packages.It maps the original path of the package to the path in
.open-next.As a follow up, we might integrate that better with the patch system.
Today,
applyCodePatchesassumes that a patch will update file content.We could modify
applyCodePatchesto take a list ofPatch.The
Patchclass would be instantiated withoptions, tracedFiles, manifests, nodePackages, nextVersionand have a publicapplymethod.We could then have derived
PatchFileContent,PatchCopyFile, ... classes.