8000 refactor: re-export the handler by name by vicb · Pull Request #804 · opennextjs/opennextjs-aws · GitHub
[go: up one dir, main page]
Skip to content

refactor: re-export the handler by name #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

refactor: re-export the handler by name #804

merged 1 commit into from
Mar 28, 2025

Conversation

vicb
Copy link
Contributor
@vicb vicb commented Mar 28, 2025

This caused an issue in Cloudflare, see opennextjs/opennextjs-cloudflare#509

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 9690e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from conico974 March 28, 2025 08:14
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.21% 2358 / 8995
🔵 Statements 26.21% 2358 / 8995
🔵 Functions 52.71% 126 / 239
🔵 Branches 73.15% 586 / 801
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-362
Generated in workflow #1112 for commit 9690e6b by the Vitest Coverage Report Action

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Mar 28, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@804

commit: 9690e6b

conico974
conico974 approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor
@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Did you figure out what is the underlying issue here ?

@vicb
Copy link
Contributor Author
vicb commented Mar 28, 2025

Not fully yet, but I'll keep investigating (probably next week)
Thanks for the review

@vicb vicb merged commit 86f4b44 into main Mar 28, 2025
3 checks passed
@vicb vicb deleted the vb-branch-4 branch March 28, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974
0