8000 Fix/1213 by samplecatalina · Pull Request #1397 · openml/openml-python · GitHub
[go: up one dir, main page]
Skip to content

Fix/1213 #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix/1213 #1397

merged 1 commit into from
Jun 16, 2025

Conversation

samplecatalina
Copy link
Contributor

Reference Issue

Fixes #1213

What does this PR implement/fix? Explain your changes.

  1. Replaced the dprecated command
  2. Added a variable to store the git status
  3. Added logging for better visibility
  4. Updated the reference in teh check step

How should this PR be tested?

Use the workflow dispatch feature, we could manually trigger it:

  1. Go to GitHub repository
  2. Click on the "Actions" tab
  3. Select the branch you want to run it on
  4. Click "Run workflow"
    This will manually trigger the workflow, allowing us to test the changes without pushing a new commit.

Any other comments?

No.

@LennartPurucker
Copy link
Contributor

Heyho @samplecatalina, thanks for the contribution. It seems you are referencing the wrong issue.

Which issue does this pull request relate to?

@samplecatalina
Copy link
Contributor Author

Heyho @samplecatalina, thanks for the contribution. It seems you are referencing the wrong issue.

Which issue does this pull request relate to?

Hi @LennartPurucker thanks for your kind reminder, my apologies for any confusion caused. I think I have accidentally forked this working branch from the other fix (#1396) I was working on, which is the reason why this PR contains two irrelevant commits to the current issue I wanted to solve here (#1213). I will see if I could open another correct PR for this #1397.

@samplecatalina
updated workflow to avoid set-output command
c6e8ee3 
updated the GitHub Actions workflow to use the new
Environment Files approach instead of the deprecated set-output command.
@samplecatalina
Copy link
Contributor Author

Heyho @samplecatalina, thanks for the contribution. It seems you are referencing the wrong issue.
Which issue does this pull request relate to?

Hi @LennartPurucker thanks for your kind reminder, my apologies for any confusion caused. I think I have accidentally forked this working branch from the other fix (#1396) I was working on, which is the reason why this PR contains two irrelevant commits to the current issue I wanted to solve here (#1213). I will see if I could open another correct PR for this #1397.

I have removed those irrelevant commits from this PR. Now the only commit titled "updated workflow to avoid set-output command" is the correct one. Please feel free to let me know if there are any other concerns, I will be more than happy to help.

@PGijsbers PGijsbers merged commit 9d28c9e into openml:develop Jun 16, 2025
1 check passed
@PGijsbers
Copy link
Collaborator

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PGijsbers PGijsbers PGijsbers approved these changes

< 51E7 input type="hidden" name="_method" value="put" autocomplete="off" />
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actions: set_output is deprecated, update to new standard
3 participants
@samplecatalina @LennartPurucker @PGijsbers
0