fix: strip patch version from CUDA_VERSION_STRING when using CUDAToolkit (#26965) #28474
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ENABLE_CUDA_FIRST_CLASS_LANGUAGE is ON, CUDAToolkit_VERSION includes the full patch version (e.g., 12.3.107), causing OpenCVConfig.cmake to require an exact patch version match. This is overly strict since CUDA APIs are stable within the same major.minor version. This fix extracts only major.minor (e.g., 12.3) from CUDAToolkit_VERSION, which is consistent with the existing FindCUDA.cmake behavior that already uses only major.minor. Fixes opencv#26965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ENABLE_CUDA_FIRST_CLASS_LANGUAGE is ON, CUDAToolkit_VERSION may include a patch component
(e.g. 12.3.107). This value is currently exported into OpenCVConfig.cmake and later used
with EXACT matching, which forces an exact patch-level CUDA version match.
This is unnecessarily strict, since CUDA APIs are stable within the same major.minor
version and patch versions change frequently.
This change extracts only the major.minor part (e.g. 12.3) from CUDAToolkit_VERSION before
exporting it, keeping the existing EXACT behavior while allowing any patch version.
This is consistent with existing FindCUDA.cmake behavior, which already operates at the
major.minor level.
Fixes #26965
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.