10000 GAPI FLUID: Enable dynamic dispatching for Merge3 by alexgiving · Pull Request #21529 · opencv/opencv · GitHub
[go: up one dir, main page]
Skip to content

GAPI FLUID: Enable dynamic dispatching for Merge3 #21529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

GAPI FLUID: Enable dynamic dispatching for Merge3 #21529

merged 1 commit into from
Feb 16, 2022

Conversation

alexgiving
Copy link
Member
@alexgiving alexgiving commented Jan 27, 2022 •
edited
Loading

Merge3 SIMD.xlsx

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux AVX2,Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
Xbuild_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.2.0

buildworker:Custom Win=windows-3

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
Xtest_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

CPU_BASELINE:Custom Win=AVX512_SKX
CPU_BASELINE:Custom=SSE4_2

@alexgiving alexgiving force-pushed the atrutnev/simd_for_merge3 branch from 9def428 to c623676 Compare February 1, 2022 10:45
anna-khakimova
anna-khakimova approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member
@anna-khakimova anna-khakimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alalek
alalek reviewed Feb 16, 2022
View reviewed changes
modules/gapi/src/backends/fluid/gfluidcore.cpp
Comment on lines +2512 to +2515
const auto *in = src.InLine<uchar>(0);
auto *out1 = dst1.OutLine<uchar>();
auto *out2 = dst2.OutLine<uchar>();
auto *out3 = dst3.OutLine<uchar>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no sense with aligning of in and out variables. They still stay unaligned. Just because they are from the different groups.

IMHO, we should not have unrelated changes in the patch. Code for review should be clear and should follow the purposes in PRs description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR is included in cascade of optimization PRs. In previous one #21520 (comment) the alignment was changed and in this PR returned to be the same as in other kernels

@dmatveev dmatveev added this to the 4.6.0 milestone Feb 16, 2022
@opencv-pushbot opencv-pushbot merged commit 5c7e893 into opencv:4.x Feb 16, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek left review comments

@dmatveev dmatveev dmatveev approved these changes

@anna-khakimova anna-khakimova anna-khakimova approved these changes

Assignees

@dmatveev dmatveev

Labels
category: g-api / gapi optimization
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alexgiving @dmatveev @alalek @anna-khakimova @opencv-pushbot
0