8000 Python submodules initialization fixes by VadimLevin · Pull Request #21478 · opencv/opencv · GitHub
[go: up one dir, main page]
Skip to content

Python submodules initialization fixes #21478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Python submodules initialization fixes #21478

merged 1 commit into from
Jan 20, 2022

Conversation

VadimLevin
Copy link
Contributor
  • Add special case handling when submodule has the same name as parent
  • PyDict_SetItemString doesn't steal reference, so reference count should be explicitly decremented to transfer object life-time ownership
    -Submodule initialization errors are propagated to the parent module initialization and ImportError is set.
  • Add sanity checks for module registration input

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin VadimLevin added bug backport is needed Label for maintainers. Authors of PR can ignore this category: python bindings labels Jan 19, 2022
@VadimLevin
fix: submodules creation and registration
eca2d92 
- Add special case handling when submodule has the same name as parent
- `PyDict_SetItemString` doesn't steal reference, so reference count
  should be explicitly decremented to transfer object life-time
  ownership
- Add sanity checks for module registration input
@VadimLevin VadimLevin force-pushed the dev/vlevin/pysubmodules-initialization-fix branch from 988bf81 to eca2d92 Compare January 19, 2022 15:07
@asmorkalov asmorkalov requested a review from alalek January 20, 2022 07:16
@opencv-pushbot opencv-pushbot merged commit 8f4473b into opencv:3.4 Jan 20, 2022
@VadimLevin VadimLevin mentioned this pull request Jan 20, 2022
Merged
6 tasks
This was referenced Jan 27, 2022
Merged
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
bug category: python bindings port/backport done Label for maintainers. Authors of PR can ignore this
Projects
None yet
Milestone
3.4.18
Development

Successfully merging this pull request may close these issues.
3 participants
@VadimLevin @alalek @opencv-pushbot
0