-
-
Notifications
You must be signed in to change notification settings - Fork 56.2k
[G-API] Implement G-API pipeline modeling tool #21477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,893 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alalek Is is possible to run these tests as part of precommit job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only functional tests are launched (with filtering capability and proper checks).
We don't test tools or samples. No plans to change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
@alalek @mshabunin Could you have a look, please? |
modules/gapi/CMakeLists.txt
Outdated
ocv_target_link_libraries(example_gapi_pipeline_builder_tool winmm.lib) | ||
endif() | ||
file(GLOB_RECURSE pipeline_builder_configs "${CMAKE_CURRENT_LIST_DIR}/samples/pipeline_builder/configs/*.yml") | ||
install(FILES ${pipeline_builder_configs} DESTINATION "${OPENCV_OTHER_INSTALL_PATH}/pipeline_builder_configs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install
COMPONENT samples
must be added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
#include <opencv2/highgui.hpp> // cv::CommandLineParser | ||
#include <opencv2/core/utils/filesystem.hpp> | ||
|
||
#if defined(WIN32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_WIN32
https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
Just WIN32
is not a compiler definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CloseHandle(timer); | ||
#else | ||
using namespace std::chrono; | ||
std::this_thread::sleep_for(duration<double, std::milli>(ms)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this code can't work with WIN32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but it doesn't work as precisely as we would like
Need to make builds green before merge. |
This reverts commit 6748a24.
- use `-DINSTALL_C_EXAMPLES=ON`
…er-tool [G-API] Implement G-API pipeline modeling tool * Implement G-API pipeline builder tool * Remove whitespaces from config * Remove unused unittest stuff * Fix comments to review * Fix MAC warning * Rename to pipeline_modeling_tool * Move to opencv apps * Move config to gapi/samples/data * gapi: samples sources are installed automatically
…er-tool [G-API] Implement G-API pipeline modeling tool * Implement G-API pipeline builder tool * Remove whitespaces from config * Remove unused unittest stuff * Fix comments to review * Fix MAC warning * Rename to pipeline_modeling_tool * Move to opencv apps * Move config to gapi/samples/data * gapi: samples sources are installed automatically
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Build configuration