Do not copy standalone IPP libraries to install for static builds #16769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalek
reviewed
Mar 10, 2020
f6a59f6 to
13e83d3
Compare
|
@alalek @mshabunin Any progress on that? |
|
The solution breaks Android with stand alone IPP. Will be discussed and decided after release. |
|
@asmorkalov , I believe users should manually add standalone IPP libraries to the Android package directory prior to the build. This feature should be incorporated into our build_sdk.py script, not only for IPP, but for other static libraries too. |
|
@mshabunin @alalek Are there any open items here? Could it be merged? |
alalek
reviewed
Apr 15, 2020
| IMPORTED_LINK_INTERFACE_LIBRARIES "" | ||
| IMPORTED_LOCATION "${FILE}" | ||
| ) | ||
| if (NOT BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
Instead of complete dropping this code, please add OPENCV_INSTALL_EXTERNAL_DEPENDENCIES option:
For example as list, including "all" (ipp in this case) - for better configuration. See here.
alalek
approved these changes
Apr 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16537
Only IPP/IPPIW binaries distributed with OpenCV should be copied to
<INSTALL>/lib/opencv4/3rdparty.Checked samples build with following configurations (Ubuntu 18):
where OPT is:
<empty>- default, use IPPICV and IPPIW from OpenCV-DIPPROOT=/opt/intel/compilers_and_libraries_2020.0.166/linux/ipp- use standalone IPP, use IPPIW from OpenCV-DIPPROOT=/opt/intel/compilers_and_libraries_2020.0.166/linux/ipp -DBUILD_IPP_IW=OFF- use standalone IPP and IPPIWPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.