8000 bad code generated for nested unions by codebutler · Pull Request #959 · openapi-generators/openapi-python-client · GitHub
[go: up one dir, main page]
Skip to content

bad code generated for nested unions #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2024
Merged

bad code generated for nested unions #959

merged 4 commits into from
Feb 20, 2024

Conversation

codebutler
Copy link
Contributor

fixes #958

@dbanty dbanty enabled auto-merge February 20, 2024 01:03
dbanty
dbanty approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator
@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A perfect PR 🙇

@dbanty dbanty disabled auto-merge February 20, 2024 01:05
@dbanty dbanty changed the title fix: bad code generated for nested unions bad code generated for nested unions Feb 20, 2024
@dbanty dbanty enabled auto-merge February 20, 2024 01:05
@dbanty dbanty added this pull request to the merge queue Feb 20, 2024
Merged via the queue into openapi-generators:main with commit 7eb4093 Feb 20, 2024
@dbanty dbanty mentioned this pull request Feb 20, 2024
Merged
dbanty added a commit that referenced this pull request Feb 20, 2024
@dbanty
chore: prepare release 0.17.3 (#970)
dbdbe33 
This PR was created by Knope. Merging it will create a new release

### Fixes

#### Remove spurious field_dict.update({}) for types without properties
(#969)

#### Fix invalid type check for nested unions

Nested union types (unions of unions) were generating `isinstance()`
checks that were not valid (at least for Python 3.9).

Thanks to @codebutler for PR #959 which fixes #958 and #967.

Co-authored-by: GitHub <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanty dbanty dbanty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid code generated for nullable discriminated union
2 participants
@codebutler @dbanty
0